[banshee] SourceManager: Prevent null TypeUniqueId



commit 04f2db348fda239e4e29d82a55e3ac5a3619e011
Author: Andres G. Aragoneses <knocte gmail com>
Date:   Sun Nov 27 03:48:05 2011 +0000

    SourceManager: Prevent null TypeUniqueId
    
    Prevent a null TypeUniqueId by using the order
    as a fallback in the same way GroupSource class
    was doing it, in case TypeUniqueId is not
    provided (by using the ctor which doesn't
    have its parameter).
    
    Fixes bgo#635656

 .../Banshee.Services/Banshee.Sources/Source.cs     |    2 +-
 .../Banshee.Sources/SourceManager.cs               |    1 -
 2 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/Core/Banshee.Services/Banshee.Sources/Source.cs b/src/Core/Banshee.Services/Banshee.Sources/Source.cs
index 20645b0..a1b065a 100644
--- a/src/Core/Banshee.Services/Banshee.Sources/Source.cs
+++ b/src/Core/Banshee.Services/Banshee.Sources/Source.cs
@@ -68,7 +68,7 @@ namespace Banshee.Sources
 
         public delegate void OpenPropertiesDelegate ();
 
-        protected Source (string generic_name, string name, int order) : this (generic_name, name, order, null)
+        protected Source (string generic_name, string name, int order) : this (generic_name, name, order, order.ToString ())
         {
         }
 
diff --git a/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs b/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs
index d0878bd..bcb556d 100644
--- a/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs
+++ b/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs
@@ -72,7 +72,6 @@ namespace Banshee.Sources
         {
             public GroupSource (string name, int order) : base (name, name, order)
             {
-                TypeUniqueId = order.ToString ();
             }
         }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]