[nautilus-actions] src/nact/nact-tree-ieditable.c: re-reverse the list before returning



commit 52d239ef6b674fe7323487d4033fff4c6854e482
Author: Pierre Wieser <pwieser trychlos org>
Date:   Sat Nov 26 22:48:06 2011 +0100

    src/nact/nact-tree-ieditable.c: re-reverse the list before returning
    
    A forgotten effect of working with pointers: the list passed to a function, and reversed in this function, returns
    changed (actually reversed) to the caller.

 ChangeLog                      |    3 +++
 src/nact/nact-tree-ieditable.c |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 6ba6f0d..808df55 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-11-26 Pierre Wieser <pwieser trychlos org>
 
+	* src/nact/nact-tree-ieditable.c (do_insert_before): Re-reverse the list
+	before returning so that the list returns as unchanged to the caller.
+
 	* src/io-desktop/nadp-desktop-file.c (nadp_desktop_file_new_from_uri):
 	Slightly optimize code.
 
diff --git a/src/nact/nact-tree-ieditable.c b/src/nact/nact-tree-ieditable.c
index 1286fea..daf5f45 100644
--- a/src/nact/nact-tree-ieditable.c
+++ b/src/nact/nact-tree-ieditable.c
@@ -743,11 +743,14 @@ nact_tree_ieditable_insert_at_path( NactTreeIEditable *instance, GList *items, G
 		actual_path = do_insert_before( ied, items, insert_path );
 
 		parent = na_object_get_parent( items->data );
+		g_debug( "%s: parent=%p", thisfn, ( void * ) parent );
 		if( parent ){
 			na_object_check_status( parent );
 		} else {
 			for( it = items ; it ; it = it->next ){
+				g_debug( "%s: checking %p", thisfn, ( void * ) it->data );
 				na_object_check_status( it->data );
+				na_object_dump( it->data );
 			}
 			g_signal_emit_by_name( ied->window, TREE_SIGNAL_LEVEL_ZERO_CHANGED, TRUE );
 		}
@@ -860,6 +863,7 @@ do_insert_before( IEditableData *ied, GList *items, GtkTreePath *asked_path )
 		}
 	}
 
+	items = g_list_reverse( reversed );
 	return( actual_path );
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]