[evolution] Bug #664018 - Cannot create task/memo from a mail
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Bug #664018 - Cannot create task/memo from a mail
- Date: Mon, 21 Nov 2011 16:54:31 +0000 (UTC)
commit a8e8c4612266db75e1f1a7a489ba3545215eb02f
Author: Milan Crha <mcrha redhat com>
Date: Mon Nov 21 17:53:17 2011 +0100
Bug #664018 - Cannot create task/memo from a mail
plugins/mail-to-task/mail-to-task.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/plugins/mail-to-task/mail-to-task.c b/plugins/mail-to-task/mail-to-task.c
index f028528..29329d2 100644
--- a/plugins/mail-to-task/mail-to-task.c
+++ b/plugins/mail-to-task/mail-to-task.c
@@ -1070,7 +1070,6 @@ mail_to_event (ECalClientSourceType source_type,
CamelFolder *folder;
GPtrArray *uids;
ESourceList *source_list = NULL;
- gboolean done = FALSE;
GSList *groups, *p;
ESource *source = NULL, *default_source = NULL;
GError *error = NULL;
@@ -1103,7 +1102,7 @@ mail_to_event (ECalClientSourceType source_type,
/* Find 'Default' source. When no source is default, ask user to pick one */
groups = e_source_list_peek_groups (source_list);
- for (p = groups; p != NULL && !done; p = p->next) {
+ for (p = groups; p != NULL; p = p->next) {
ESourceGroup *group = E_SOURCE_GROUP (p->data);
GSList *sources, *q;
@@ -1113,8 +1112,6 @@ mail_to_event (ECalClientSourceType source_type,
if (s && e_source_get_property (s, "default") && !e_source_get_readonly (s)) {
default_source = s;
- done = TRUE;
- break;
}
if (s && !e_source_get_readonly (s)) {
@@ -1124,7 +1121,7 @@ mail_to_event (ECalClientSourceType source_type,
}
}
- if (!default_source && writable_sources > 1) {
+ if (writable_sources > 1) {
GtkWidget *dialog;
/* ask the user which tasks list to save to */
@@ -1142,7 +1139,7 @@ mail_to_event (ECalClientSourceType source_type,
gtk_widget_destroy (dialog);
} else if (!source && default_source) {
source = default_source;
- } else {
+ } else if (!source) {
e_notice (NULL, GTK_MESSAGE_ERROR, _("No writable calendar is available."));
g_object_unref (source_list);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]