[extensions-web] Show the download URL when viewing a binary file
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] Show the download URL when viewing a binary file
- Date: Sat, 19 Nov 2011 21:58:29 +0000 (UTC)
commit 937a3754c86bc44af282452aa8f9e91bf1f9b5d9
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Sat Nov 19 16:53:54 2011 -0500
Show the download URL when viewing a binary file
sweettooth/review/views.py | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index 201c359..78106d8 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -82,7 +82,7 @@ def highlight_file(filename, raw, formatter):
return pygments.highlight(raw, lexer, formatter)
-def html_for_file(filename, raw):
+def html_for_file(filename, version, raw):
base, extension = os.path.splitext(filename)
if extension in IMAGE_TYPES:
@@ -92,6 +92,12 @@ def html_for_file(filename, raw):
return dict(html='<img src="data:%s;base64,%s">' % (mime, raw_base64,),
num_lines=0)
+ elif extension in BINARY_TYPES:
+ download_url = reverse('review-download', kwargs=dict(pk=version.pk))
+ html = "<p>This file is binary. Please <a href=\"%s\">" \
+ "download the zipfile</a> to see it.</p>" % (download_url,)
+
+ return dict(html=html, num_lines=0)
else:
return dict(html=highlight_file(filename, raw, code_formatter),
num_lines=len(raw.strip().splitlines()))
@@ -198,7 +204,7 @@ def ajax_get_file_view(request, obj):
raise Http404()
raw = f.read()
- return html_for_file(filename, raw)
+ return html_for_file(filename, obj, raw)
def download_zipfile(request, uuid):
pk = request.GET['pk']
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]