[librsvg] Add extra NULL check here
- From: Christian Persch <chpe src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [librsvg] Add extra NULL check here
- Date: Mon, 14 Nov 2011 12:44:07 +0000 (UTC)
commit b1390cbfa7d173753d708f1db38d3f7e8d69deae
Author: Christian Persch <chpe gnome org>
Date: Mon Nov 14 13:43:55 2011 +0100
Add extra NULL check here
rsvg-css.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/rsvg-css.c b/rsvg-css.c
index 29f0ed4..e3e368b 100644
--- a/rsvg-css.c
+++ b/rsvg-css.c
@@ -817,7 +817,6 @@ rsvg_css_parse_xml_attribute_string (const char *attribute_string)
xmlDocPtr doc;
xmlNodePtr node;
xmlAttrPtr attr;
- int ret;
char *tag;
GPtrArray *attributes;
char **retval = NULL;
@@ -828,9 +827,7 @@ rsvg_css_parse_xml_attribute_string (const char *attribute_string)
xmlSAX2InitDefaultSAXHandler (&handler, 0);
handler.serror = rsvg_xml_noerror;
parser = xmlCreatePushParserCtxt (&handler, NULL, tag, strlen (tag) + 1, NULL);
- ret = xmlParseDocument (parser);
-
- if (ret != 0)
+ if (xmlParseDocument (parser) != 0)
goto done;
if ((doc = parser->myDoc) == NULL ||
@@ -855,7 +852,8 @@ rsvg_css_parse_xml_attribute_string (const char *attribute_string)
retval = (char **) g_ptr_array_free (attributes, FALSE);
done:
- xmlFreeDoc (parser->myDoc);
+ if (parser->myDoc)
+ xmlFreeDoc (parser->myDoc);
xmlFreeParserCtxt (parser);
g_free (tag);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]