[empathy] Remove dead files codec-preferences and element-preferences
- From: Danielle Madeley <daniellem src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [empathy] Remove dead files codec-preferences and element-preferences
- Date: Tue, 8 Nov 2011 00:23:18 +0000 (UTC)
commit 64a173ce325b9ba30079ce5b9f3bbe1615302ecb
Author: Danielle Madeley <danielle madeley collabora co uk>
Date: Tue Nov 8 11:17:56 2011 +1100
Remove dead files codec-preferences and element-preferences
These are now handled for us by Farsight. Hooray for Farsight.
configure.ac | 2 +-
data/Makefile.am | 6 ---
data/codec-preferences | 50 ----------------------------
data/element-properties | 59 ----------------------------------
src/empathy-streamed-media-handler.c | 23 -------------
src/empathy-streamed-media-window.c | 24 ++++----------
6 files changed, 8 insertions(+), 156 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index a5050f7..c67ed59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,7 +43,7 @@ KEYRING_REQUIRED=2.26.0
GCR_REQUIRED=2.91.4
LIBCANBERRA_GTK_REQUIRED=0.25
LIBNOTIFY_REQUIRED=0.7.0
-TELEPATHY_FARSIGHT_REQUIRED=0.0.14
+TELEPATHY_FARSIGHT_REQUIRED=0.0.18
TELEPATHY_GLIB_REQUIRED=0.16.0
TELEPATHY_LOGGER=0.2.10
WEBKIT_REQUIRED=1.3.13
diff --git a/data/Makefile.am b/data/Makefile.am
index e6414a8..a08ed62 100644
--- a/data/Makefile.am
+++ b/data/Makefile.am
@@ -19,11 +19,6 @@ convertdir = $(datarootdir)/GConf/gsettings
convert_DATA = \
empathy.convert
-streamingprefsdir = $(datadir)/empathy
-streamingprefs_DATA = \
- codec-preferences \
- element-properties
-
servicefiledir = $(datadir)/dbus-1/services
servicefile_in_files = \
org.freedesktop.Telepathy.Client.Empathy.Chat.service.in \
@@ -76,7 +71,6 @@ EXTRA_DIST = \
$(desktop_in_files) \
$(desktop_DATA) \
$(schemas_DATA) \
- $(streamingprefs_DATA) \
$(html_DATA) \
$(clientfile_DATA) \
$(servicefile_in_files) \
diff --git a/src/empathy-streamed-media-handler.c b/src/empathy-streamed-media-handler.c
index 67527d8..a3c5397 100644
--- a/src/empathy-streamed-media-handler.c
+++ b/src/empathy-streamed-media-handler.c
@@ -708,27 +708,6 @@ empathy_streamed_media_handler_tf_channel_closed_cb (TfChannel *tfchannel,
g_signal_emit (G_OBJECT (handler), signals[CLOSED], 0);
}
-static GList *
-empathy_streamed_media_handler_tf_channel_codec_config_cb (TfChannel *channel,
- guint stream_id, FsMediaType media_type, guint direction, gpointer user_data)
-{
- gchar *filename = empathy_file_lookup ("codec-preferences", "data");
- GList *codecs;
- GError *error = NULL;
-
- codecs = fs_codec_list_from_keyfile (filename, &error);
- g_free (filename);
-
- if (!codecs)
- {
- g_warning ("No codec-preferences file: %s",
- error ? error->message : "No error message");
- }
- g_clear_error (&error);
-
- return codecs;
-}
-
static void
empathy_streamed_media_handler_start_tpfs (EmpathyStreamedMediaHandler *self)
{
@@ -748,8 +727,6 @@ empathy_streamed_media_handler_start_tpfs (EmpathyStreamedMediaHandler *self)
G_CALLBACK (empathy_streamed_media_handler_tf_channel_stream_created_cb), self);
g_signal_connect (priv->tfchannel, "closed",
G_CALLBACK (empathy_streamed_media_handler_tf_channel_closed_cb), self);
- g_signal_connect (priv->tfchannel, "stream-get-codec-config",
- G_CALLBACK (empathy_streamed_media_handler_tf_channel_codec_config_cb), self);
g_object_unref (channel);
}
diff --git a/src/empathy-streamed-media-window.c b/src/empathy-streamed-media-window.c
index c74910b..22ecbd2 100644
--- a/src/empathy-streamed-media-window.c
+++ b/src/empathy-streamed-media-window.c
@@ -35,6 +35,7 @@
#include <telepathy-glib/util.h>
#include <gst/farsight/fs-element-added-notifier.h>
+#include <gst/farsight/fs-utils.h>
#include <libempathy/empathy-tp-contact-factory.h>
#include <libempathy/empathy-utils.h>
@@ -981,8 +982,6 @@ empathy_streamed_media_window_init (EmpathyStreamedMediaWindow *self)
GtkWidget *arrow;
GtkWidget *page;
gchar *filename;
- GKeyFile *keyfile;
- GError *error = NULL;
GtkWidget *scroll;
filename = empathy_file_lookup ("empathy-streamed-media-window.ui", "src");
@@ -1084,21 +1083,6 @@ empathy_streamed_media_window_init (EmpathyStreamedMediaWindow *self)
/* The call will be started as soon the pipeline is playing */
priv->start_call_when_playing = TRUE;
- keyfile = g_key_file_new ();
- filename = empathy_file_lookup ("element-properties", "data");
- if (g_key_file_load_from_file (keyfile, filename, G_KEY_FILE_NONE, &error))
- {
- fs_element_added_notifier_set_properties_from_keyfile (priv->fsnotifier,
- keyfile);
- }
- else
- {
- g_warning ("Could not load element-properties file: %s", error->message);
- g_key_file_free (keyfile);
- g_clear_error (&error);
- }
- g_free (filename);
-
priv->vbox = gtk_vbox_new (FALSE, 3);
gtk_box_pack_start (GTK_BOX (priv->content_hbox), priv->vbox,
FALSE, FALSE, CONTENT_HBOX_CHILDREN_PACKING_PADDING);
@@ -1759,6 +1743,12 @@ empathy_streamed_media_window_conference_added_cb (EmpathyStreamedMediaHandler *
{
EmpathyStreamedMediaWindow *self = EMPATHY_STREAMED_MEDIA_WINDOW (user_data);
EmpathyStreamedMediaWindowPriv *priv = GET_PRIV (self);
+ GKeyFile *keyfile;
+
+ keyfile = fs_utils_get_default_element_properties (conference);
+ if (keyfile != NULL)
+ fs_element_added_notifier_set_properties_from_keyfile (priv->fsnotifier,
+ keyfile);
gst_bin_add (GST_BIN (priv->pipeline), conference);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]