[extensions-web] Use an if/elif chain instead of setattr for the inline field view
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] Use an if/elif chain instead of setattr for the inline field view
- Date: Mon, 7 Nov 2011 16:00:51 +0000 (UTC)
commit 8b3d6f5c929049691a48ed4b1171cda7fd419e91
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Tue Nov 1 16:52:53 2011 -0400
Use an if/elif chain instead of setattr for the inline field view
sweettooth/extensions/views.py | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index fc9f68f..a1a5226 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -131,11 +131,15 @@ def ajax_inline_edit_view(request, obj):
if key.startswith('extension_'):
key = key[len('extension_'):]
- whitelist = 'name', 'description', 'url'
- if key not in whitelist:
+ if key == 'name':
+ obj.name = value
+ elif key == 'description':
+ obj.description = value
+ elif key == 'url':
+ obj.url = value
+ else:
return HttpResponseForbidden()
- setattr(obj, key, value)
obj.save()
return value
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]