[goffice] GOString: plug leak.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [goffice] GOString: plug leak.
- Date: Thu, 3 Nov 2011 14:03:58 +0000 (UTC)
commit dc01cdd7ef4bd566a9d1fb53cc7f5a878d2519f4
Author: Morten Welinder <terra gnome org>
Date: Thu Nov 3 10:03:06 2011 -0400
GOString: plug leak.
ChangeLog | 6 +++++-
NEWS | 1 +
goffice/utils/go-string.c | 2 ++
3 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index dbe5cf0..682adef 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2011-11-03 Morten Welinder <terra gnome org>
+
+ * goffice/utils/go-string.c (go_string_new_rich): Plug leak.
+
2011-10-31 Jean Brefort <jean brefort normalesup org>
* goffice/graph/gog-object.c (cb_size_changed),
(cb_manual_size_changed), (gog_object_populate_editor): made the manual
@@ -5,7 +9,7 @@
* goffice/gtk/goffice-gtk.c (go_gui_get_image_save_info): don't ask for
the extension when file type is unknown.
* goffice/utils/go-image.c (go_image_get_format_from_name),
- (go_image_new_from_data): fixed behavior with unknown format.
+ (go_image_new_from_data): fixed behavior with unknown format.
2011-10-30 Jean Brefort <jean brefort normalesup org>
diff --git a/NEWS b/NEWS
index 8db837c..fd52d21 100644
--- a/NEWS
+++ b/NEWS
@@ -43,6 +43,7 @@ Morten:
* Fix problem with sticky format colouring.
* Improve certain range functions in corner cases. [#660564]
* Add resource manager for embedded files.
+ * Plug leaks.
Gerald Niel:
* Plugins not found when using in bundle for Mac OSX. [#661264]
diff --git a/goffice/utils/go-string.c b/goffice/utils/go-string.c
index 5048bd1..84ba42d 100644
--- a/goffice/utils/go-string.c
+++ b/goffice/utils/go-string.c
@@ -245,6 +245,8 @@ go_string_new_rich (char const *str,
g_hash_table_insert (go_strings_base, rich, rich);
} else {
go_string_ref (&base->base);
+ if (!copy)
+ g_free (str);
rich->base.base.str = base->base.str;
rich->base.flags |= GO_STRING_IS_DEPENDENT;
if ((base->flags & GO_STRING_IS_SHARED)) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]