[glib] GHash: Avoid nonatomic access to the reference count



commit abf719362a5c17854557542cc21fe93ae04419d7
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat May 28 21:40:12 2011 -0400

    GHash: Avoid nonatomic access to the reference count
    
    Not really necessary to constantly double-check the ref
    count, anyway.

 glib/ghash.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/glib/ghash.c b/glib/ghash.c
index ecf8dfa..54db82e 100644
--- a/glib/ghash.c
+++ b/glib/ghash.c
@@ -839,7 +839,6 @@ GHashTable*
 g_hash_table_ref (GHashTable *hash_table)
 {
   g_return_val_if_fail (hash_table != NULL, NULL);
-  g_return_val_if_fail (hash_table->ref_count > 0, hash_table);
 
   g_atomic_int_inc (&hash_table->ref_count);
 
@@ -861,7 +860,6 @@ void
 g_hash_table_unref (GHashTable *hash_table)
 {
   g_return_if_fail (hash_table != NULL);
-  g_return_if_fail (hash_table->ref_count > 0);
 
   if (g_atomic_int_dec_and_test (&hash_table->ref_count))
     {
@@ -889,7 +887,6 @@ void
 g_hash_table_destroy (GHashTable *hash_table)
 {
   g_return_if_fail (hash_table != NULL);
-  g_return_if_fail (hash_table->ref_count > 0);
 
   g_hash_table_remove_all (hash_table);
   g_hash_table_unref (hash_table);
@@ -995,7 +992,6 @@ g_hash_table_insert_internal (GHashTable *hash_table,
   gpointer old_value;
 
   g_return_if_fail (hash_table != NULL);
-  g_return_if_fail (hash_table->ref_count > 0);
 
   if (G_UNLIKELY (hash_table->keys == hash_table->values && key != value))
     hash_table->values = g_memdup (hash_table->keys, sizeof (gpointer) * hash_table->size);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]