[gnome-shell/gnome-3-0] PopupSliderMenuItem: intercept clicks outside the slider



commit 2afb4cc124db2eec389f8236d140074fa13b13a0
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Thu Apr 21 17:49:41 2011 +0200

    PopupSliderMenuItem: intercept clicks outside the slider
    
    Connect to button-press-event on the menu item actor, not on the
    slider, so any part that is highlighted is also clicked. This means
    that click on the left of the volume slider is a rapid way to mute.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646660

 js/ui/popupMenu.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index b1dcf49..4e0ffea 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -498,7 +498,7 @@ PopupSliderMenuItem.prototype = {
         this._slider = new St.DrawingArea({ style_class: 'popup-slider-menu-item', reactive: true });
         this.addActor(this._slider, { span: -1, expand: true });
         this._slider.connect('repaint', Lang.bind(this, this._sliderRepaint));
-        this._slider.connect('button-press-event', Lang.bind(this, this._startDragging));
+        this.actor.connect('button-press-event', Lang.bind(this, this._startDragging));
         this.actor.connect('scroll-event', Lang.bind(this, this._onScrollEvent));
 
         this._releaseId = this._motionId = 0;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]