[gtk+/parser] styleproperties: Use the pspec as the hash table key



commit f1ac685b4a455d003d4741d6f004d2fed6eb2db1
Author: Benjamin Otte <otte redhat com>
Date:   Mon May 16 22:22:42 2011 +0200

    styleproperties: Use the pspec as the hash table key
    
    The code used the quarked name before, but when we already have the
    pspec we want to have a lookup that does not involve quarking. And
    lookup is equally fast if we only have the name.

 gtk/gtkstyleproperties.c |   26 ++++++++------------------
 1 files changed, 8 insertions(+), 18 deletions(-)
---
diff --git a/gtk/gtkstyleproperties.c b/gtk/gtkstyleproperties.c
index dc615d2..2bb8f5a 100644
--- a/gtk/gtkstyleproperties.c
+++ b/gtk/gtkstyleproperties.c
@@ -708,15 +708,12 @@ gtk_style_properties_set_property (GtkStyleProperties *props,
     g_return_if_fail (node->pspec->value_type == value_type);
 
   priv = props->priv;
-  prop = g_hash_table_lookup (priv->properties,
-                              GINT_TO_POINTER (node->property_quark));
+  prop = g_hash_table_lookup (priv->properties, node->pspec);
 
   if (!prop)
     {
       prop = property_data_new ();
-      g_hash_table_insert (priv->properties,
-                           GINT_TO_POINTER (node->property_quark),
-                           prop);
+      g_hash_table_insert (priv->properties, node->pspec, prop);
     }
 
   val = property_data_get_value (prop, state);
@@ -772,15 +769,12 @@ gtk_style_properties_set_valist (GtkStyleProperties *props,
           break;
         }
 
-      prop = g_hash_table_lookup (priv->properties,
-                                  GINT_TO_POINTER (node->property_quark));
+      prop = g_hash_table_lookup (priv->properties, node->pspec);
 
       if (!prop)
         {
           prop = property_data_new ();
-          g_hash_table_insert (priv->properties,
-                               GINT_TO_POINTER (node->property_quark),
-                               prop);
+          g_hash_table_insert (priv->properties, node->pspec, prop);
         }
 
       val = property_data_get_value (prop, state);
@@ -957,8 +951,7 @@ _gtk_style_properties_peek_property (GtkStyleProperties *props,
     }
 
   priv = props->priv;
-  prop = g_hash_table_lookup (priv->properties,
-                              GINT_TO_POINTER (node->property_quark));
+  prop = g_hash_table_lookup (priv->properties, node->pspec);
 
   if (!prop)
     return NULL;
@@ -1010,8 +1003,7 @@ gtk_style_properties_get_property (GtkStyleProperties *props,
     }
 
   priv = props->priv;
-  prop = g_hash_table_lookup (priv->properties,
-                              GINT_TO_POINTER (node->property_quark));
+  prop = g_hash_table_lookup (priv->properties, node->pspec);
 
   if (!prop)
     return FALSE;
@@ -1072,8 +1064,7 @@ gtk_style_properties_get_valist (GtkStyleProperties *props,
           break;
         }
 
-      prop = g_hash_table_lookup (priv->properties,
-                                  GINT_TO_POINTER (node->property_quark));
+      prop = g_hash_table_lookup (priv->properties, node->pspec);
 
       if (prop)
         val = property_data_match_state (prop, state);
@@ -1165,8 +1156,7 @@ gtk_style_properties_unset_property (GtkStyleProperties *props,
     }
 
   priv = props->priv;
-  prop = g_hash_table_lookup (priv->properties,
-                              GINT_TO_POINTER (node->property_quark));
+  prop = g_hash_table_lookup (priv->properties, node->pspec);
 
   if (!prop)
     return;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]