[banshee/gst#] gst#: Drop additional Pipeline.
- From: Christopher James Halse Rogers <chrishr src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee/gst#] gst#: Drop additional Pipeline.
- Date: Sun, 15 May 2011 09:36:39 +0000 (UTC)
commit 2da3ab7045b077fd4aedeb7a12cd853dcd95d294
Author: Christopher James Halse Rogers <chrishr src gnome org>
Date: Sun May 15 00:14:43 2011 +0200
gst#: Drop additional Pipeline.
PlayBin2 is already a Pipeline. We don't get anything
extra by putting it into an explicit pipeline.
.../Banshee.GStreamerSharp/PlayerEngine.cs | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
---
diff --git a/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs b/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
index 334f7cb..75b8e3d 100644
--- a/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
+++ b/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
@@ -53,7 +53,6 @@ namespace Banshee.GStreamerSharp
{
public class PlayerEngine : Banshee.MediaEngine.PlayerEngine
{
- Pipeline pipeline;
PlayBin2 playbin;
uint iterate_timeout_id = 0;
List<string> missing_details = new List<string> ();
@@ -82,15 +81,13 @@ namespace Banshee.GStreamerSharp
}
Gst.Application.Init ();
- pipeline = new Pipeline ();
playbin = new PlayBin2 ();
- pipeline.Add (playbin);
// Remember the volume from last time
Volume = (ushort)PlayerEngineService.VolumeSchema.Get ();
playbin.AddNotification ("volume", OnVolumeChanged);
- pipeline.Bus.AddWatch (OnBusMessage);
+ playbin.Bus.AddWatch (OnBusMessage);
OnStateChanged (PlayerState.Ready);
}
@@ -292,8 +289,8 @@ namespace Banshee.GStreamerSharp
protected override void OpenUri (SafeUri uri, bool maybeVideo)
{
- if (pipeline.CurrentState == State.Playing || pipeline.CurrentState == State.Paused) {
- pipeline.SetState (Gst.State.Ready);
+ if (playbin.CurrentState == State.Playing || playbin.CurrentState == State.Paused) {
+ playbin.SetState (Gst.State.Ready);
}
playbin.Uri = uri.AbsoluteUri;
@@ -304,19 +301,19 @@ namespace Banshee.GStreamerSharp
// HACK, I think that directsoundsink has a bug that resets its volume to 1.0 every time
// This seems to fix bgo#641427
Volume = Volume;
- pipeline.SetState (Gst.State.Playing);
+ playbin.SetState (Gst.State.Playing);
OnStateChanged (PlayerState.Playing);
}
public override void Pause ()
{
- pipeline.SetState (Gst.State.Paused);
+ playbin.SetState (Gst.State.Paused);
OnStateChanged (PlayerState.Paused);
}
public override void Close (bool fullShutdown)
{
- pipeline.SetState (State.Null);
+ playbin.SetState (State.Null);
base.Close (fullShutdown);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]