[beast] PLUGINS: added davorgan cleanups from 2006 review
- From: Tim Janik <timj src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [beast] PLUGINS: added davorgan cleanups from 2006 review
- Date: Sun, 8 May 2011 17:23:38 +0000 (UTC)
commit 71abae2fd17d9fe060e669088cd5cc6340c160e0
Author: Tim Janik <timj gtk org>
Date: Sun May 8 19:02:20 2011 +0200
PLUGINS: added davorgan cleanups from 2006 review
plugins/davorgan.cc | 6 +++---
plugins/davorgan.idl | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/plugins/davorgan.cc b/plugins/davorgan.cc
index 13ad0e2..5b34063 100644
--- a/plugins/davorgan.cc
+++ b/plugins/davorgan.cc
@@ -40,7 +40,7 @@ class Organ : public OrganBase {
int i;
/* Initialize sine table. */
for (i = 0; i < rate; i++)
- m_sine_table[i] = sin ((i / rate) * 2.0 * PI) / 6.0;
+ m_sine_table[i] = sin (i / rate * 2.0 * PI) / 6.0;
/* Initialize triangle table. */
for (i = 0; i < rate / 2; i++)
m_triangle_table[i] = (4 / rate * i - 1.0) / 6.0;
@@ -51,7 +51,7 @@ class Organ : public OrganBase {
* \_/
*/
for (i = 0; i < slope; i++)
- m_pulse_table[i] = (-i / slope) / 6.0;
+ m_pulse_table[i] = -i / slope / 6.0;
for (; i < half - slope; i++)
m_pulse_table[i] = -1.0 / 6.0;
for (; i < half + slope; i++)
@@ -63,7 +63,7 @@ class Organ : public OrganBase {
}
~Tables()
{} // private destructor; use ref_counting
- static map<uint, Tables*> table_map; /* rate -> rate specific tables */
+ static map<uint, Tables*> table_map; // map of rate specific tables
static Mutex table_mutex;
public:
static Tables*
diff --git a/plugins/davorgan.idl b/plugins/davorgan.idl
index 10f0094..107097d 100644
--- a/plugins/davorgan.idl
+++ b/plugins/davorgan.idl
@@ -25,7 +25,7 @@ class Organ : Effect {
Info authors = "David A. Bartold";
Info license = _("GNU Lesser General Public License");
Info category = _("/Audio Sources/Organ");
- Info blurb = _("DavOrgan is a modifiable additive organ synthesizer");
+ Info blurb = _("DavOrgan is a versatile additive organ synthesizer");
IStream freq_in = (_("Freq In"), _("Frequency Input"));
OStream audio_out = (_("Audio Out"), _("Organ output"));
group _("Base Frequency") {
@@ -34,9 +34,9 @@ class Organ : Effect {
Int base_note = Note (_("Note"), _("Organ frequency as note, converted to Hertz according to the current musical tuning"),
BSE_KAMMER_NOTE, GUI);
Int transpose = Int (_("Transpose"), _("Transposition of the frequency in semitones"),
- 0, BSE_MIN_TRANSPOSE, BSE_MAX_TRANSPOSE, 12, STANDARD ":f:dial:skip-default");
+ 0, BSE_MIN_TRANSPOSE, BSE_MAX_TRANSPOSE, 12, STANDARD ":dial:skip-default");
Int fine_tune = FineTune (_("Fine Tune"), _("Amount of detuning in cent (hundredth part of a semitone)"),
- STANDARD ":f:dial:skip-default");
+ STANDARD ":dial:skip-default");
};
group _("Harmonics") {
Real harm0 = Perc (_("16th"), _("16th Harmonic"), 100.0, STANDARD ":scale");
@@ -47,9 +47,9 @@ class Organ : Effect {
Real harm5 = Perc (_("2nd"), _("2nd Harmonic"), 100. * 55. / 127., STANDARD ":scale");
};
group _("Instrument flavour") {
- Bool brass = Bool (_("Brass Sounds"), _("Changes the organ to sound more brassy"), FALSE, STANDARD);
- Bool reed = Bool (_("Reed Sounds"), _("Adds reeds sound"), FALSE, STANDARD);
- Bool flute = Bool (_("Flute Sounds"), _("Adds flute sounds"), FALSE, STANDARD);
+ Bool brass = Bool (_("Brass Sounds"), _("Change the organ to sound more brassy"), false, STANDARD);
+ Bool reed = Bool (_("Reed Sounds"), _("Add reeds sound"), false, STANDARD);
+ Bool flute = Bool (_("Flute Sounds"), _("Add flute sounds"), false, STANDARD);
};
};
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]