[aravis] gv_device: add a TODO for using hearbeat timeout register for heartbeat.



commit dec8630bc0aad4fc7ee615c5b0711aefe37a3123
Author: Emmanuel Pacaud <emmanuel gnome org>
Date:   Fri May 6 10:35:38 2011 +0200

    gv_device: add a TODO for using hearbeat timeout register for heartbeat.

 src/arvgvdevice.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/src/arvgvdevice.c b/src/arvgvdevice.c
index 0e57ef5..b5410f4 100644
--- a/src/arvgvdevice.c
+++ b/src/arvgvdevice.c
@@ -338,6 +338,11 @@ arv_gv_device_heartbeat_thread (void *data)
 
 	do {
 		if (io_data->is_controller) {
+
+			/* TODO: Instead of reading the control register, Pylon does write the heartbeat
+			 * timeout value, which is interresting, as doing this we could get an error
+			 * ack packet which will indicate we lost the control access. */
+
 			g_usleep (thread_data->period_us);
 			_read_register (io_data, ARV_GVBS_CONTROL_CHANNEL_PRIVILEGE_OFFSET, &value);
 			arv_debug ("device", "[GvDevice::Heartbeat] (%d)", value);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]