[gnumeric] FileOpen: plug leak.



commit 09a5b6d9f8fe4fd42c0bccbe28a81ef38e204831
Author: Morten Welinder <terra gnome org>
Date:   Thu Mar 31 16:01:30 2011 -0400

    FileOpen: plug leak.

 ChangeLog      |    4 ++++
 NEWS           |    1 +
 src/gui-file.c |    3 ++-
 3 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 0b9a832..3da07ae 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2011-03-31  Morten Welinder  <terra gnome org>
+
+	* src/gui-file.c (gui_file_open): Plug leak.
+
 2011-03-30  Morten Welinder  <terra gnome org>
 
 	* src/func.c (dump_externals): Properly use translation domain.
diff --git a/NEWS b/NEWS
index fad68f5..8360b8f 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ Andreas:
 
 Morten:
 	* Fix problems with localized function docs.
+	* Plug leak.
 
 --------------------------------------------------------------------------
 Gnumeric 1.10.14
diff --git a/src/gui-file.c b/src/gui-file.c
index 7b10455..b31def6 100644
--- a/src/gui-file.c
+++ b/src/gui-file.c
@@ -329,8 +329,9 @@ gui_file_open (WBCGtk *wbcg, char const *default_format)
 		gtk_label_set_mnemonic_widget (GTK_LABEL (data.charmap_label),
 					       go_charmap_sel);
 
+		g_object_ref_sink (box);
 		g_object_set_data_full (G_OBJECT (advanced_button), "extra",
-			g_object_ref (box), g_object_unref);
+					box, g_object_unref);
 #ifdef GNM_USE_HILDON
 		/*
 		 * Don't need to show the vbox. This is here just to avoid the warning :



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]