[vino] Add dbus-glib-1 to telepathy-glib pkg-config check



commit 362f5da8adb7879b403788173dbad6cb27dd6d39
Author: David King <amigadave amigadave com>
Date:   Tue Mar 29 08:31:13 2011 +0200

    Add dbus-glib-1 to telepathy-glib pkg-config check
    
    In recent linker versions, transitive imports of library symbols are
    rejected by the linker. dbus-glib-1 exists in the Requires.private
    variable of the telepathy-glib pkg-config file, so results in a
    transitive import of dbus-glib-1, which fails during the link phase as
    dbus_g_type_specialized_construct is called from
    server/vino-tube-server.c. Underlinking is another term for this
    problem.
    
    Explicitly adding dbus-glib-1 to the telepathy-glib pkg-config check
    fixes the problem, bug 646018. Also see
    http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index f5fcd29..cde1333 100644
--- a/configure.ac
+++ b/configure.ac
@@ -50,7 +50,7 @@ AS_IF([test "x$GLIB_MKENUMS" = "x"],
     AC_MSG_RESULT([$GLIB_MKENUMS])])
 
 # Check for telepathy-glib
-TELEPATHY_GLIB_DEPS="telepathy-glib >= 0.11.6"
+TELEPATHY_GLIB_DEPS="dbus-glib-1 telepathy-glib >= 0.11.6"
 
 AC_ARG_WITH([telepathy],
   [AS_HELP_STRING([--without-telepathy],



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]