[gnome-shell] messageTray: fix clicking on links again



commit 31b12635d1d97f4f709599138e0a41248398012a
Author: Dan Winship <danw gnome org>
Date:   Wed Mar 23 16:05:38 2011 -0400

    messageTray: fix clicking on links again
    
    The change to make Notification an StButton (06d2c0af, bug 642978)
    broke links, because the link actor would ignore the
    button-press-event, allowing the notification actor to receive it and
    get a pointer grab, and so the link actor would never see the
    button-release-event. Fix that by accepting and discarding the
    button-press-event.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=645613

 js/ui/messageTray.js |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index f951801..f592f48 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -108,6 +108,12 @@ URLHighlighter.prototype = {
         }
 
         this.setMarkup(text, allowMarkup);
+        this.actor.connect('button-press-event', function() {
+            // Keep Notification.actor from seeing this and taking
+            // a pointer grab, which would block our button-release-event
+            // handler
+            return true;
+        });
         this.actor.connect('button-release-event', Lang.bind(this, function (actor, event) {
             let urlId = this._findUrlAtPos(event);
             if (urlId != -1) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]