[gtk+] Make selectable labels work again
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Make selectable labels work again
- Date: Thu, 24 Mar 2011 16:46:29 +0000 (UTC)
commit 4a86e5b1389ea1549d5cfdddddc2e4eb25e97158
Author: Matthias Clasen <mclasen redhat com>
Date: Thu Mar 24 12:44:03 2011 -0400
Make selectable labels work again
You can select something, but moving the focus somewhere else, or bringing up
the context menu makes the selection go away. This makes it impossible to
copy-paste the text.
The reason for this regression is that gtk_label_state_changed was sloppy and
assumed that it would only ever be called when a labels goes insensitive, which
is no longer the case.
The patch fixes things by explicitly checking if the widget is insensitive, and
only resetting the selection in that case, which is the same behaviour we have
for e.g. GtkEntry.
gtk/gtklabel.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 51fd17f..9f7c7ad 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -3808,7 +3808,9 @@ gtk_label_state_changed (GtkWidget *widget,
if (priv->select_info)
{
- gtk_label_select_region (label, 0, 0);
+ if (!gtk_widget_is_sensitive (widget))
+ gtk_label_select_region (label, 0, 0);
+
gtk_label_update_cursor (label);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]