[gnome-shell] NotificationDaemon: fix typo in dealing with TrayIcon



commit 953004886756e6e68b272d576eac608476ef8cdc
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Wed Mar 23 21:37:05 2011 +0100

    NotificationDaemon: fix typo in dealing with TrayIcon
    
    Source was failing to determine if it was a tray icon, destroying
    itself when the associated application was closed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=645625

 js/ui/notificationDaemon.js |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js
index f8f356e..c3ae212 100644
--- a/js/ui/notificationDaemon.js
+++ b/js/ui/notificationDaemon.js
@@ -519,10 +519,13 @@ Source.prototype = {
     _appStateChanged: function() {
         // Destroy notification sources when their apps exit.
         // The app exiting would normally result in a tray icon being removed,
-        // so it should be ok to destroy the source associated with a tray icon
-        // here too, however we just let that happen through the code path
-        // associated with the tray icon being removed.
-        if (!this._isTrayIcon && this.app.get_state() == Shell.AppState.STOPPED)
+        // so the associated source would be destroyed through the code path
+        // that handles the tray icon being removed. We should not destroy
+        // the source associated with a tray icon when the application state
+        // is Shell.AppState.STOPPED because running applications that have
+        // no open windows would also have that state. This is often the case
+        // for applications that use tray icons.
+        if (!this._trayIcon && this.app.get_state() == Shell.AppState.STOPPED)
             this.destroy();
     },
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]