[gnome-session] gsm-manager: Add comment with historical context
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-session] gsm-manager: Add comment with historical context
- Date: Thu, 17 Mar 2011 16:14:53 +0000 (UTC)
commit c01831c0dea7f6728106ae12090b248f37ad1feb
Author: Colin Walters <walters verbum org>
Date: Thu Mar 10 16:14:14 2011 -0500
gsm-manager: Add comment with historical context
https://bugzilla.gnome.org/show_bug.cgi?id=642497
gnome-session/gsm-manager.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
---
diff --git a/gnome-session/gsm-manager.c b/gnome-session/gsm-manager.c
index 23b9374..f7616ec 100644
--- a/gnome-session/gsm-manager.c
+++ b/gnome-session/gsm-manager.c
@@ -621,6 +621,15 @@ _start_app (const char *id,
}
if (manager->priv->phase < GSM_MANAGER_PHASE_APPLICATION) {
+ /* Historical note - apparently,
+ * e.g. gnome-settings-daemon used to "daemonize", and
+ * so gnome-session assumes process exit means "ok
+ * we're done". Of course this is broken, we don't
+ * even distinguish between exit code 0 versus not-0,
+ * nor do we have any metadata which tells us a
+ * process is going to "daemonize" or not (and
+ * basically nothing should be anyways).
+ */
g_signal_connect (app,
"exited",
G_CALLBACK (app_registered),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]