[glibmm] FileInfo: Added more TODOs about using ustring instead of std::string.



commit 4c4096d2901c4cbdbffac472fb032ad956f53fa8
Author: Murray Cumming <murrayc murrayc com>
Date:   Fri Mar 11 10:05:57 2011 +0100

    FileInfo: Added more TODOs about using ustring instead of std::string.
    
    * gio/src/fileinfo.hg:
    See https://bugzilla.gnome.org/show_bug.cgi?id=615950#c7
    (Kjell Ahlstedt)

 ChangeLog           |    8 ++++++++
 gio/src/fileinfo.hg |    6 ++++++
 2 files changed, 14 insertions(+), 0 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 37b35c4..dfc859b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-03-11  Murray Cumming  <murrayc murrayc com>
+
+	FileInfo: Added more TODOs about using ustring instead of std::string.
+
+	* gio/src/fileinfo.hg:
+	See https://bugzilla.gnome.org/show_bug.cgi?id=615950#c7
+	(Kjell Ahlstedt)
+
 2011-03-11  Kjell Ahlstedt  <kjell ahlstedt bredband net>
 
 	Tell gmmproc that it reads and writes UTF-8 files.
diff --git a/gio/src/fileinfo.hg b/gio/src/fileinfo.hg
index 550a608..b3638c5 100644
--- a/gio/src/fileinfo.hg
+++ b/gio/src/fileinfo.hg
@@ -99,8 +99,11 @@ public:
                g_file_info_get_attribute_type)
   _WRAP_METHOD(void remove_attribute(const std::string& attribute),
                g_file_info_remove_attribute)
+
+  //TODO: This should return a ustring instead: https://bugzilla.gnome.org/show_bug.cgi?id=615950#c7
   _WRAP_METHOD(std::string get_attribute_string(const std::string& attribute) const,
                g_file_info_get_attribute_string)
+
   _WRAP_METHOD(Glib::ustring get_attribute_as_string(const std::string& attribute) const,
                g_file_info_get_attribute_as_string)
   _WRAP_METHOD(std::string get_attribute_byte_string(const std::string& attribute) const,
@@ -117,8 +120,11 @@ public:
                g_file_info_get_attribute_int64)
   _WRAP_METHOD(Glib::RefPtr<Glib::Object> get_attribute_object(const std::string& attribute) const,
                g_file_info_get_attribute_object)
+
+  //TODO: This should take a ustring value instead: https://bugzilla.gnome.org/show_bug.cgi?id=615950#c7
   _WRAP_METHOD(void set_attribute_string(const std::string& attribute, const std::string& value),
                g_file_info_set_attribute_string)
+
   _WRAP_METHOD(void set_attribute_byte_string(const std::string& attribute, const std::string& value),
                g_file_info_set_attribute_byte_string)
   _WRAP_METHOD(void set_attribute_boolean(const std::string& attribute, bool value),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]