[libgnome-keyring] This assertion is vulnerable to corner conditions.
- From: Stefan Walter <stefw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgnome-keyring] This assertion is vulnerable to corner conditions.
- Date: Thu, 10 Mar 2011 16:13:41 +0000 (UTC)
commit 84103a1d29e66ede966874e4af4b17706605cd48
Author: Stef Walter <stefw collabora co uk>
Date: Thu Mar 10 17:12:23 2011 +0100
This assertion is vulnerable to corner conditions.
In particular if the operation completes one pending call, unrefs it
and creates another pending call, and the memory allocator decides
to allocate that same memory for the next pending call, then this
will assert in a bogus way.
https://bugzilla.redhat.com/show_bug.cgi?id=660407
library/gkr-operation.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/library/gkr-operation.c b/library/gkr-operation.c
index 7600cd7..0fbba4d 100644
--- a/library/gkr-operation.c
+++ b/library/gkr-operation.c
@@ -404,7 +404,6 @@ gkr_operation_block_and_unref (GkrOperation *op)
if (op->pending == pending) {
g_return_val_if_fail (dbus_pending_call_get_completed (pending), BROKEN);
on_pending_call_notify (pending, op);
- g_assert (op->pending != pending);
}
} else if (op->prompting) {
dbus_connection_flush (op->conn);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]