[sawfish] Crash prevention from wrong theme codes.



commit fd548abb74bc1010e3b4d1d235a277bd1f49ae60
Author: Teika kazura <teika lavabit com>
Date:   Tue Mar 8 13:33:32 2011 +0900

    Crash prevention from wrong theme codes.
    
    It's a regression of 1.7.0.
    This code should go to librep, but I put it in Sawfish for convenience.
    Fix in librep won't interfere.
    
    Some options in mxflat still make Sawfish crash.

 lisp/sawfish/wm/gaol.jl |    6 +++++-
 man/news.texi           |    6 ++++++
 2 files changed, 11 insertions(+), 1 deletions(-)
---
diff --git a/lisp/sawfish/wm/gaol.jl b/lisp/sawfish/wm/gaol.jl
index daad892..e529147 100644
--- a/lisp/sawfish/wm/gaol.jl
+++ b/lisp/sawfish/wm/gaol.jl
@@ -59,7 +59,11 @@
   (define safe-specials
     '(default-foreground display-name canonical-display-name
       default-font default-frame nil-frame frame-part-classes
-      decorate-transients batch-mode default-directory))
+      decorate-transients batch-mode default-directory
+      ;; This should be in librep, but I added it here, too.
+      ;; Without this, wrong theme codes make Sawfish crash.
+      ;; It's ok for librep to fix it, too.
+      %in-condition-case))
 
   (define safe-features '(sawfish.wm.util.gtkrc
 			  sawfish.wm.util.x
diff --git a/man/news.texi b/man/news.texi
index b9045b1..859cee6 100644
--- a/man/news.texi
+++ b/man/news.texi
@@ -125,6 +125,12 @@ Sawfish wrongly reported a focus change during a grab as
 
 Some windows were skipped in window cycles among groups. This is fixed.
 
+ item No more crash at loading wrong theme code [Teika Kazura]
+
+From Sawfish-1.7.0, Sawfish used to crash when a theme with wrong code
+is loaded, but it's fixed. It's not complete, and for example some
+mxflat options make Sawfish crash.
+
 @item Cancellation of @code{call-command} [Teika kazura]
 
 It used to print an error message when you cancel an interactive call of



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]