[goffice] GUI: Plug leaks.



commit 1879460dcd0af5de074ce5b17b4ae583333d3ce8
Author: Morten Welinder <terra gnome org>
Date:   Sat Jun 18 12:25:46 2011 -0400

    GUI: Plug leaks.

 ChangeLog                        |   10 +++++++++-
 NEWS                             |    3 +++
 goffice/graph/gog-series.c       |    6 ++++--
 goffice/gtk/go-marker-selector.c |    1 +
 4 files changed, 17 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d82cf07..27cdf65 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-06-18  Morten Welinder  <terra gnome org>
+
+	* goffice/gtk/go-marker-selector.c
+	(go_marker_palette_render_func): Plug leak.
+
+	* goffice/graph/gog-series.c (gog_series_populate_editor): Make
+	sure we free the GtkBuilder object.
+
 2011-06-16  Morten Welinder <terra gnome org>
 
 	* configure.in: Post-release bump.
@@ -9,7 +17,7 @@
 2011-06-10  Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* configure.in: check for get_gsf_odf_version
-	* goffice/utils/go-format.c (go_format_output_fraction_to_odf): 
+	* goffice/utils/go-format.c (go_format_output_fraction_to_odf):
 	don't just assume that we are writing ODF 1.2
 
 2011-06-08  Andreas J. Guelzow <aguelzow pyrshep ca>
diff --git a/NEWS b/NEWS
index ee592f3..3bc4c0f 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
 goffice 0.8.17:
 
+Morten:
+	* Plug leaks.
+
 --------------------------------------------------------------------------
 goffice 0.8.16:
 
diff --git a/goffice/graph/gog-series.c b/goffice/graph/gog-series.c
index f4c8740..1fa8d64 100644
--- a/goffice/graph/gog-series.c
+++ b/goffice/graph/gog-series.c
@@ -596,8 +596,10 @@ gog_series_populate_editor (GogObject *gobj,
 				gtk_widget_set_sensitive (widget, FALSE);
 			widget = go_gtk_builder_get_widget (gui, "fill_type_prefs");
 			gtk_box_pack_start (GTK_BOX (box), widget, TRUE, TRUE, 0);
-			g_object_set_data_full (G_OBJECT (widget), "gui", gui,
-						(GDestroyNotify) g_object_unref);
+			g_object_set_data (G_OBJECT (widget), "gui", gui);
+
+			g_signal_connect_swapped (G_OBJECT (widget), "destroy",
+						  G_CALLBACK (g_object_unref), gui);
 		}
 	}
 
diff --git a/goffice/gtk/go-marker-selector.c b/goffice/gtk/go-marker-selector.c
index 8b34c17..c2b2f6d 100644
--- a/goffice/gtk/go-marker-selector.c
+++ b/goffice/gtk/go-marker-selector.c
@@ -55,6 +55,7 @@ go_marker_palette_render_func (cairo_t *cr,
 	cairo_stroke (cr);
 
 	go_marker_render (marker, cr, area->x + area->width / 2.0, area->y + area->height / 2.0, 1.0);
+	g_object_unref (marker);
 }
 
 /**



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]