[pitivi: 14/16] Check that the settings are changed before signalling that they have been changed. Fixes bug 646513



commit ec748cc3930d0f531730d9c3dd737754c6717b5e
Author: Alex BÄ?luÈ? <alexandru balut gmail com>
Date:   Thu May 26 17:02:00 2011 +0200

    Check that the settings are changed before signalling that they have been changed.
    Fixes bug 646513

 pitivi/ui/encodingdialog.py |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)
---
diff --git a/pitivi/ui/encodingdialog.py b/pitivi/ui/encodingdialog.py
index eb6ce36..ff30909 100644
--- a/pitivi/ui/encodingdialog.py
+++ b/pitivi/ui/encodingdialog.py
@@ -386,9 +386,19 @@ class EncodingDialog(Renderer, Loggable):
         self.destroy()
 
     def _updateProjectSettings(self):
-        """Updates the settings of the project."""
-        # TODO: Do this only when the settings actually changed.
+        """Updates the settings of the project if the render settings changed.
+        """
         settings = self.project.getSettings()
+        if (settings.muxer == self.settings.muxer
+            and settings.aencoder == self.settings.aencoder
+            and settings.vencoder == self.settings.vencoder
+            and settings.containersettings == self.settings.containersettings
+            and settings.acodecsettings == self.settings.acodecsettings
+            and settings.vcodecsettings == self.settings.vcodecsettings
+            and settings.render_scale == self.settings.render_scale):
+            # No setting which can be changed in the Render dialog
+            # and which we want to save have been changed.
+            return
         settings.setEncoders(muxer=self.settings.muxer,
                              aencoder=self.settings.aencoder,
                              vencoder=self.settings.vencoder)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]