[pitivi] Properly set the advanced codec settings dialog's modality
- From: Thibault Saunier <tsaunier src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi] Properly set the advanced codec settings dialog's modality
- Date: Tue, 7 Jun 2011 01:40:42 +0000 (UTC)
commit 55e38e1bffb5ca2d9bfde563ffab69dbb8aa9c3f
Author: Jean-François Fortin Tam <nekohayo gmail com>
Date: Mon Jun 6 15:44:58 2011 -0400
Properly set the advanced codec settings dialog's modality
Set transient state to parent it with encodingdialog.
Don't show elementsettingsdialog until readied by gstwidget.
data/ui/elementsettingsdialog.ui | 2 +-
pitivi/ui/encodingdialog.py | 1 +
pitivi/ui/gstwidget.py | 1 +
3 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/data/ui/elementsettingsdialog.ui b/data/ui/elementsettingsdialog.ui
index 65c73b0..a4f2881 100644
--- a/data/ui/elementsettingsdialog.ui
+++ b/data/ui/elementsettingsdialog.ui
@@ -2,7 +2,7 @@
<interface>
<!-- interface-requires gtk+ 2.6 -->
<object class="GtkDialog" id="dialog1">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="border_width">12</property>
<property name="title" translatable="yes">Properties for <element></property>
diff --git a/pitivi/ui/encodingdialog.py b/pitivi/ui/encodingdialog.py
index a65d371..3dfaab3 100644
--- a/pitivi/ui/encodingdialog.py
+++ b/pitivi/ui/encodingdialog.py
@@ -293,6 +293,7 @@ class EncodingDialog(Renderer, Loggable):
factory = get_combo_value(combo)
settings = getattr(self.settings, settings_attr)
dialog = GstElementSettingsDialog(factory, settings)
+ dialog.window.set_transient_for(self.window)
response = dialog.window.run()
if response == gtk.RESPONSE_OK:
diff --git a/pitivi/ui/gstwidget.py b/pitivi/ui/gstwidget.py
index 0a329e3..976ef4d 100644
--- a/pitivi/ui/gstwidget.py
+++ b/pitivi/ui/gstwidget.py
@@ -197,6 +197,7 @@ class GstElementSettingsDialog(Loggable):
self.warning("Couldn't create element from factory %s", self.factory)
self.properties = properties
self._fillWindow()
+ self.window.show()
def _fillWindow(self):
# set title and frame label
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]