[libgda/LIBGDA_4.2] Fix some more compiler warnings.



commit b44f401b58e24e91bdca1afb60e97309d9eec898
Author: Vivien Malerba <malerba gnome-db org>
Date:   Sun Jul 24 19:15:16 2011 +0200

    Fix some more compiler warnings.
    
    * libgda/gda-data-model.c: (gda_data_model_set_values): Fix a
      signed/unsigned warning.
    * libgda-ui/data-entries/gdaui-entry-bin.c: (popup_position):
      Remove the call to
      gtk_widget_size_request() because the result is not used.
    * libgda-ui/data-entries/widget-embedder.c:
      (widget_embedder_size_allocate): Remove the call to
      gtk_widget_get_child_requisition() because the result is not used.

 libgda-ui/data-entries/gdaui-entry-bin.c |    3 ---
 libgda-ui/data-entries/widget-embedder.c |    2 --
 libgda/gda-data-model.c                  |    2 +-
 3 files changed, 1 insertions(+), 6 deletions(-)
---
diff --git a/libgda-ui/data-entries/gdaui-entry-bin.c b/libgda-ui/data-entries/gdaui-entry-bin.c
index c89f8b5..59e05be 100644
--- a/libgda-ui/data-entries/gdaui-entry-bin.c
+++ b/libgda-ui/data-entries/gdaui-entry-bin.c
@@ -329,9 +329,6 @@ popup_position (PopupContainer *container, gint *out_x, gint *out_y)
 	poswidget = g_object_get_data (G_OBJECT (container), "__poswidget");
 
 	gint x, y;
-        GtkRequisition req;
-
-        gtk_widget_size_request (poswidget, &req);
 
 #if GTK_CHECK_VERSION(2,18,0)
         gdk_window_get_origin (gtk_widget_get_window (poswidget), &x, &y);
diff --git a/libgda-ui/data-entries/widget-embedder.c b/libgda-ui/data-entries/widget-embedder.c
index b6de50d..b66089c 100644
--- a/libgda-ui/data-entries/widget-embedder.c
+++ b/libgda-ui/data-entries/widget-embedder.c
@@ -333,10 +333,8 @@ widget_embedder_size_allocate (GtkWidget     *widget,
 	}
 
 	if (bin->child && gtk_widget_get_visible (bin->child)){
-		GtkRequisition child_requisition;
 		GtkAllocation child_allocation;
 		
-		gtk_widget_get_child_requisition (bin->child, &child_requisition);
 		child_allocation.x = 0;
 		child_allocation.y = 0;
 		child_allocation.height = h;
diff --git a/libgda/gda-data-model.c b/libgda/gda-data-model.c
index 52bea37..9eb30e7 100644
--- a/libgda/gda-data-model.c
+++ b/libgda/gda-data-model.c
@@ -780,7 +780,7 @@ gda_data_model_set_values (GdaDataModel *model, gint row, GList *values, GError
 		/* save the values */
 		gint col, ncols;
 		ncols = gda_data_model_get_n_columns (model);
-		if (g_list_length (values) > ncols) {
+		if ((gint)g_list_length (values) > ncols) {
 			g_set_error (error, GDA_DATA_MODEL_ERROR,  GDA_DATA_MODEL_VALUES_LIST_ERROR,
 				     "%s", _("Too many values in list"));
 			return FALSE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]