[gnome-subtitles] Code review



commit 25616813912e845f02b0f2eeb6e163ec7ad394a8
Author: Pedro Castro <pedro gnomesubtitles org>
Date:   Sat Jul 16 19:20:00 2011 +0100

    Code review

 .../Core/Command/FixedMultipleSelectionCommand.cs  |    2 +-
 src/GnomeSubtitles/Ui/View/SubtitleSelection.cs    |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/GnomeSubtitles/Core/Command/FixedMultipleSelectionCommand.cs b/src/GnomeSubtitles/Core/Command/FixedMultipleSelectionCommand.cs
index 27557ef..49d5ea2 100644
--- a/src/GnomeSubtitles/Core/Command/FixedMultipleSelectionCommand.cs
+++ b/src/GnomeSubtitles/Core/Command/FixedMultipleSelectionCommand.cs
@@ -62,7 +62,7 @@ public abstract class FixedMultipleSelectionCommand : MultipleSelectionCommand {
 		}
 		Base.Ui.View.Refresh();
 		if (reselect)
-			Base.Ui.View.Selection.Reselect();  //TODO check where reselect is needed, there might be a better approach to this
+			Base.Ui.View.Selection.Reselect();
 		
 		PostProcess();
 		return true;
diff --git a/src/GnomeSubtitles/Ui/View/SubtitleSelection.cs b/src/GnomeSubtitles/Ui/View/SubtitleSelection.cs
index a7f1e1c..2b20bdd 100644
--- a/src/GnomeSubtitles/Ui/View/SubtitleSelection.cs
+++ b/src/GnomeSubtitles/Ui/View/SubtitleSelection.cs
@@ -324,7 +324,8 @@ public class SubtitleSelection {
 		selection.SelectAll();
 	}
 	
-	//TODO Check why this is needed
+	/// <summary>Needed for the selection-dependent widgets to refresh when the contents of a selection are changed
+	/// while the selection itself isn't. Example: applying styles to a single selected subtitle</summary>
     public void Reselect () {
     	EmitChangedEvent();
     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]