[frogr] Don't use static variables for GAppInfo instances
- From: Mario Sanchez Prada <msanchez src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [frogr] Don't use static variables for GAppInfo instances
- Date: Sat, 16 Jul 2011 20:08:47 +0000 (UTC)
commit cde917bffc9d1003521e031e570fc443f18b4ee8
Author: Mario Sanchez Prada <msanchez igalia com>
Date: Sat Jul 16 21:55:14 2011 +0200
Don't use static variables for GAppInfo instances
src/frogr-util.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/frogr-util.c b/src/frogr-util.c
index b9e95da..90bd105 100644
--- a/src/frogr-util.c
+++ b/src/frogr-util.c
@@ -169,17 +169,15 @@ _get_uris_string_from_list (GList *uris_list)
void
frogr_util_open_images_in_viewer (GList *uris_list)
{
- static GAppInfo *app_info = NULL;
+ GAppInfo *app_info = NULL;
GError *error = NULL;
/* Early return */
if (!uris_list)
return;
- if (!app_info)
- app_info = g_app_info_get_default_for_type ("image/jpg", TRUE);
-
- if (!g_app_info_launch_uris (app_info, uris_list, NULL, &error))
+ app_info = g_app_info_get_default_for_type ("image/jpg", TRUE);
+ if (!app_info || !g_app_info_launch_uris (app_info, uris_list, NULL, &error))
{
/* The default app didn't succeed, so try 'gnome-open' / 'open' */
@@ -205,6 +203,9 @@ frogr_util_open_images_in_viewer (GList *uris_list)
DEBUG ("Error opening %d images: %s", g_list_length (uris_list), error->message);
g_error_free (error);
}
+
+ if (app_info)
+ g_object_unref (app_info);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]