[libdmapsharing] Copy service_name/name strings (thanks Daniel Svensson)



commit abd8e182e90db73d0bbc21ba8ed3cc9941d01681
Author: W. Michael Petullo <mike flyn org>
Date:   Sun Jul 3 19:45:07 2011 -0500

    Copy service_name/name strings (thanks Daniel Svensson)
    
    See also https://bugzilla.gnome.org/show_bug.cgi?id=653859.
    Signed-off-by: W. Michael Petullo <mike flyn org>

 TODO                                     |    4 ++++
 libdmapsharing/dmap-mdns-browser-dnssd.c |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/TODO b/TODO
index 15722af..f5ccc48 100644
--- a/TODO
+++ b/TODO
@@ -1,5 +1,7 @@
 = Short term ===================================================================
 
+Use decodebin2, see dmapd.
+
 Noah: DNS-SD implementation
 	Finish browser side support.
 	Update MacPorts port to no longer require avahi.
@@ -29,6 +31,8 @@ Mike: Audit remaining GSoC patch:
 --- dacp-share.c
 --- dacp-share.h
 
+Mike: Add support for browse= on DMAPConnection side to filter results (see dmap-share.c).
+
 Mike: Functions that could be simplified:
 	compare_record_property()
 	apply_filter()/_dmap_share_build_filter() (lex/yacc?)
diff --git a/libdmapsharing/dmap-mdns-browser-dnssd.c b/libdmapsharing/dmap-mdns-browser-dnssd.c
index 935052a..ef9212e 100644
--- a/libdmapsharing/dmap-mdns-browser-dnssd.c
+++ b/libdmapsharing/dmap-mdns-browser-dnssd.c
@@ -363,8 +363,8 @@ dmap_mdns_browser_resolve (DMAPMdnsBrowser * browser,
 	// FIXME: The name and service_name variables need to be renamed.
 	// Wait until working on DACP because I think this is when
 	// they are different. See Avahi code.
-	service->service_name = name;
-	service->name = name;
+	service->service_name = g_strdup (name);
+	service->name = g_strdup (name);
 	service->host = g_strdup (browser->priv->host_target);
 	service->port = browser->priv->port;
 	service->pair = NULL;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]