[gnome-shell] Avoid passing 'source' as an argument to Notification::destroy()



commit 20b7d3457746633cfff36535c046763b1001d5ea
Author: Marina Zhurakhinskaya <marinaz redhat com>
Date:   Sun Jan 30 18:08:20 2011 -0500

    Avoid passing 'source' as an argument to Notification::destroy()
    
    Notification::destroy() now takes 'reason' as an optional argument.
    Calling Notification::destroy() directly when connecting to 'destroy'
    on Source, as we did before, was inadvertently passing 'source' as an
    argument to the function.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640976

 js/ui/messageTray.js |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index c3eb706..81997df 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -274,7 +274,11 @@ Notification.prototype = {
         this._capturedEventId = 0;
         this._keyPressId = 0;
 
-        source.connect('destroy', Lang.bind(this, this.destroy));
+        source.connect('destroy', Lang.bind(this,
+            // Avoid passing 'source' as an argument to this.destroy()
+            function () {
+                this.destroy();
+            }));
 
         this.actor = new St.Table({ name: 'notification',
                                     reactive: true });



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]