[gegl] GeglPath: add comments about suspicious code detected by clang



commit 76ef34b391bd8989a00dbc82bcfdd4f60c1c5a8f
Author: �yvind Kolås <pippin gimp org>
Date:   Mon Jan 24 22:36:33 2011 +0000

    GeglPath: add comments about suspicious code detected by clang

 gegl/property-types/gegl-path.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gegl/property-types/gegl-path.c b/gegl/property-types/gegl-path.c
index 16def64..a4b5657 100644
--- a/gegl/property-types/gegl-path.c
+++ b/gegl/property-types/gegl-path.c
@@ -1310,10 +1310,10 @@ void gegl_path_parse_string (GeglPath *vector,
           InstructionInfo *info = lookup_instruction_info(type);
           if (!info && ((type>= '0' && type <= '9') || type == '-'))
             {
-              if (!previnfo)
+              if (!previnfo)   /* XXX: suspicious code !!! */
                 {
                   info = previnfo;
-                  type = previnfo->type;
+                  type = previnfo->type;  /* XXX: previnfo _is_ NULL */
                 }
               else
                 {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]