[glade/offscreen-design-layout] * gladeui/glade-editor-property.c, gladeui/glade-widget-adaptor.c: Pluggin more memory leaks.
- From: Juan Pablo Ugarte <jpu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glade/offscreen-design-layout] * gladeui/glade-editor-property.c, gladeui/glade-widget-adaptor.c: Pluggin more memory leaks.
- Date: Sat, 22 Jan 2011 17:51:12 +0000 (UTC)
commit f842a994cec11901dfc7c49799bf9d6a627176ea
Author: Tristan Van Berkom <tristan van berkom gmail com>
Date: Wed Jan 19 01:36:03 2011 +0900
* gladeui/glade-editor-property.c, gladeui/glade-widget-adaptor.c: Pluggin more memory leaks.
ChangeLog | 2 ++
gladeui/glade-editor-property.c | 17 +++++++++++++++++
gladeui/glade-widget-adaptor.c | 7 +++++--
3 files changed, 24 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c5fd462..453786f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,8 @@
* plugins/gtk+/gtk+.xml.in: Remove GtkTreeSelection from the palette, it's only available
as the internal selection of a GtkTreeView.
+ * gladeui/glade-editor-property.c, gladeui/glade-widget-adaptor.c: Pluggin more memory leaks.
+
2011-01-16 Tristan Van Berkom <tristanvb openismus com>
* plugins/gtk+/glade-gtk.c: Fixed warnings from glade_gtk_box_get_first_blank() when
diff --git a/gladeui/glade-editor-property.c b/gladeui/glade-editor-property.c
index 5003cd1..433f3da 100644
--- a/gladeui/glade-editor-property.c
+++ b/gladeui/glade-editor-property.c
@@ -344,6 +344,8 @@ glade_editor_property_constructor (GType type,
eprop->priv->label = gtk_label_new (NULL);
gtk_event_box_set_visible_window (GTK_EVENT_BOX (eprop->priv->item_label), FALSE);
+ g_object_ref_sink (eprop->priv->item_label);
+
hbox = gtk_hbox_new (FALSE, 4);
gtk_label_set_line_wrap (GTK_LABEL (eprop->priv->label), TRUE);
@@ -381,6 +383,20 @@ glade_editor_property_finalize (GObject * object)
}
static void
+glade_editor_property_dispose (GObject * object)
+{
+ GladeEditorProperty *eprop = GLADE_EDITOR_PROPERTY (object);
+
+ if (eprop->priv->item_label)
+ {
+ g_object_unref (eprop->priv->item_label);
+ eprop->priv->item_label = NULL;
+ }
+
+ G_OBJECT_CLASS (table_class)->dispose (object);
+}
+
+static void
glade_editor_property_set_property (GObject * object,
guint prop_id,
const GValue * value, GParamSpec * pspec)
@@ -563,6 +579,7 @@ glade_editor_property_class_init (GladeEditorPropertyClass * eprop_class)
/* GObjectClass */
object_class->constructor = glade_editor_property_constructor;
object_class->finalize = glade_editor_property_finalize;
+ object_class->dispose = glade_editor_property_dispose;
object_class->get_property = glade_editor_property_real_get_property;
object_class->set_property = glade_editor_property_set_property;
diff --git a/gladeui/glade-widget-adaptor.c b/gladeui/glade-widget-adaptor.c
index 2220ba5..87c9d66 100644
--- a/gladeui/glade-widget-adaptor.c
+++ b/gladeui/glade-widget-adaptor.c
@@ -728,15 +728,18 @@ glade_widget_adaptor_real_set_property (GObject * object,
break;
case PROP_CATALOG:
/* assume once (construct-only) */
+ g_free (adaptor->priv->catalog);
adaptor->priv->catalog = g_value_dup_string (value);
break;
case PROP_BOOK:
/* assume once (construct-only) */
+ g_free (adaptor->priv->book);
adaptor->priv->book = g_value_dup_string (value);
break;
case PROP_SPECIAL_TYPE:
- /* assume once (construct-only) */
- adaptor->priv->special_child_type = g_value_dup_string (value);
+ /* assume once (construct-only) */
+ g_free (adaptor->priv->special_child_type);
+ adaptor->priv->special_child_type = g_value_dup_string (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]