[gnome-shell] overview: Always return a value in _onDragMotion()



commit df3560143d07207b17af7fb7e33b7aec4238c998
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Jan 20 16:46:55 2011 +0100

    overview: Always return a value in _onDragMotion()
    
    Drag monitor functions are supposed to return a value, but
    _onDragMotion() does not always do so. Add the missing return
    value and remove unnecessary else.

 js/ui/overview.js |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/overview.js b/js/ui/overview.js
index 7aa2423..35c1b05 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -207,9 +207,9 @@ Overview.prototype = {
 
         if (targetIsWindow &&
             dragEvent.targetActor._delegate.metaWindow == this._lastHoveredWindow)
-            return;
-        else
-            this._lastHoveredWindow = null;
+            return DND.DragMotionResult.CONTINUE;
+
+        this._lastHoveredWindow = null;
 
         if (this._windowSwitchTimeoutId != 0) {
             Mainloop.source_remove(this._windowSwitchTimeoutId);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]