[gnumeric] fix critical on combo view popup



commit a8b9d4fe2ddd3ad36def98956d1bee86a881d821
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Sat Jan 15 11:58:02 2011 -0700

    fix critical on combo view popup
    
    2011-01-15  Andreas J. Guelzow <aguelzow pyrshep ca>
    
    	* gnm-cell-combo-view.c (gnm_cell_combo_view_popdown): wait for the
    	gdkwindow to be set before rtetrieving it.

 src/widgets/ChangeLog             |    5 +++++
 src/widgets/gnm-cell-combo-view.c |    3 ++-
 2 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/src/widgets/ChangeLog b/src/widgets/ChangeLog
index b2aa660..bc30d6c 100644
--- a/src/widgets/ChangeLog
+++ b/src/widgets/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-15  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+	* gnm-cell-combo-view.c (gnm_cell_combo_view_popdown): wait for the
+	gdkwindow to be set before rtetrieving it.
+	
 2011-01-12  Jean Brefort  <jean brefort normalesup org>
 
 	* gnumeric-expr-entry.c (gee_class_init): dynamically test for
diff --git a/src/widgets/gnm-cell-combo-view.c b/src/widgets/gnm-cell-combo-view.c
index 40a8214..21aa5ca 100644
--- a/src/widgets/gnm-cell-combo-view.c
+++ b/src/widgets/gnm-cell-combo-view.c
@@ -282,7 +282,6 @@ gnm_cell_combo_view_popdown (SheetObjectView *sov, guint32 activate_time)
 	GdkWindow *popup_window;
 
 	popup = gtk_window_new (GTK_WINDOW_POPUP);
-	popup_window = gtk_widget_get_window (popup);
 
 	gtk_window_set_type_hint (GTK_WINDOW (popup), GDK_WINDOW_TYPE_HINT_COMBO);
 	gtk_window_group_add_window (gtk_window_get_group (toplevel), GTK_WINDOW (popup));
@@ -393,6 +392,8 @@ gnm_cell_combo_view_popdown (SheetObjectView *sov, guint32 activate_time)
 	gtk_widget_grab_focus (GTK_WIDGET (list));
 	ccombo_focus_change (GTK_WIDGET (list), TRUE);
 
+	popup_window = gtk_widget_get_window (popup);
+
 	if (0 == gdk_pointer_grab (popup_window, TRUE,
 		GDK_BUTTON_PRESS_MASK |
 		GDK_BUTTON_RELEASE_MASK |



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]