[gnome-utils] logview-prefs: NULL-terminate pointer arrays



commit 189e747432479635ead9e95214294df73770f815
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Mon Jan 10 18:45:54 2011 +0100

    logview-prefs: NULL-terminate pointer arrays
    
    So we don't loop outside of the array's bounds while reading them later.

 logview/logview-prefs.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/logview/logview-prefs.c b/logview/logview-prefs.c
index 0bda514..d411f2c 100644
--- a/logview/logview-prefs.c
+++ b/logview/logview-prefs.c
@@ -279,8 +279,10 @@ save_filters (LogviewPrefs *prefs)
   g_hash_table_foreach (prefs->priv->filters,
                         save_filter_foreach_func,
                         filters);
+  g_ptr_array_add (filters, NULL);
 
   filters_strv = (gchar **) g_ptr_array_free (filters, FALSE);
+
   g_settings_set_strv (prefs->priv->logview_prefs,
                        PREF_FILTERS,
                        (const gchar **) filters_strv);
@@ -446,7 +448,9 @@ logview_prefs_remove_stored_log (LogviewPrefs *prefs, GFile *target)
     g_object_unref (stored);
   }
 
+  g_ptr_array_add (new_value, NULL);
   g_strfreev (stored_logs);
+
   stored_logs = (gchar **) g_ptr_array_free (new_value, FALSE);
 
   g_settings_set_strv (prefs->priv->logview_prefs,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]