[yelp] Fix silly buffer overflow



commit 9a2a76991622ec08c0680932097fddcb3f8ebd5a
Author: Rupert Swarbrick <rswarbrick gmail com>
Date:   Mon Jan 10 01:31:17 2011 +0000

    Fix silly buffer overflow

 libyelp/yelp-uri.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/libyelp/yelp-uri.c b/libyelp/yelp-uri.c
index b7b5534..aa467d6 100644
--- a/libyelp/yelp-uri.c
+++ b/libyelp/yelp-uri.c
@@ -965,10 +965,10 @@ decode_url (const gchar *url)
 {
     if (!url) return NULL;
 
-    unsigned int len = strlen (url) + 1;
+    unsigned int len = strlen (url);
     int hex;
-    gchar *ret = g_new (gchar, len);
-    const gchar *ptr = url, *end = url+len;
+    gchar *ret = g_new (gchar, len + 1);
+    const gchar *ptr = url, *end = url + len;
     gchar *retptr = ret, *tmp;
 
     while (ptr < end) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]