[gnumeric] help: improve consistency checks.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] help: improve consistency checks.
- Date: Fri, 7 Jan 2011 16:02:23 +0000 (UTC)
commit 243b13210dc223cf72092f532afaad5aecfba3a8
Author: Morten Welinder <terra gnome org>
Date: Fri Jan 7 11:00:53 2011 -0500
help: improve consistency checks.
ChangeLog | 5 +++++
src/func.c | 16 +++++++++++++++-
2 files changed, 20 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index cfdbcb6..500ed8c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-07 Morten Welinder <terra gnome org>
+
+ * src/func.c (gnm_func_sanity_check1): Improve check of
+ description text to catch stuff like #631504.
+
2011-01-06 Morten Welinder <terra gnome org>
* src/go-data-cache-field.c (go_data_cache_field_get_val): Undo
diff --git a/src/func.c b/src/func.c
index 2928036..e1d2f7d 100644
--- a/src/func.c
+++ b/src/func.c
@@ -649,13 +649,27 @@ gnm_func_sanity_check1 (GnmFunc const *fd)
g_hash_table_insert (allargs, argname, argname);
break;
}
- case GNM_FUNC_HELP_DESCRIPTION:
+ case GNM_FUNC_HELP_DESCRIPTION: {
+ const char *p;
+
if (check_argument_refs (h->text, fd)) {
g_printerr ("%s: Invalid argument reference in description\n",
fd->name);
res = 1;
}
+
+ p = h->text;
+ while (*p && g_ascii_isupper (*p))
+ p++;
+ if (*p == ' ' && p - h->text >= 2) {
+ if (g_ascii_strncasecmp (h->text, fd->name, nlen)) {
+ g_printerr ("%s: Wrong function name in description\n",
+ fd->name);
+ res = 1;
+ }
+ }
break;
+ }
case GNM_FUNC_HELP_EXAMPLES:
if (h->text[0] == '=') {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]