[gnome-shell] Ensure that all signatures are defined in DBus interfaces



commit 0d2eb76cee15adf2fb8307eaab42529fbab21786
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Sat Feb 26 19:21:10 2011 +0100

    Ensure that all signatures are defined in DBus interfaces
    
    The DBus JS binding will complain if the signature of a method
    or of a signal is undefined, so we need to define it even if it
    is an empty string, and we need to use the correct property name
    for signals.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=643374

 js/misc/gnomeSession.js   |    3 ++-
 js/ui/endSessionDialog.js |    2 +-
 js/ui/status/power.js     |    2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/js/misc/gnomeSession.js b/js/misc/gnomeSession.js
index ef4ef84..ce4e7e9 100644
--- a/js/misc/gnomeSession.js
+++ b/js/misc/gnomeSession.js
@@ -7,7 +7,8 @@ const Signals = imports.signals;
 const PresenceIface = {
     name: 'org.gnome.SessionManager.Presence',
     methods: [{ name: 'SetStatus',
-                inSignature: 'u' }],
+                inSignature: 'u',
+                outSignature: '' }],
     properties: [{ name: 'status',
                    signature: 'u',
                    access: 'readwrite' }],
diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js
index be64427..08c5705 100644
--- a/js/ui/endSessionDialog.js
+++ b/js/ui/endSessionDialog.js
@@ -54,7 +54,7 @@ const EndSessionDialogIface = {
               }
              ],
     signals: [{ name: 'Canceled',
-                outSignature: '',
+                inSignature: '',
               }],
     properties: []
 };
diff --git a/js/ui/status/power.js b/js/ui/status/power.js
index 263d48e..9446933 100644
--- a/js/ui/status/power.js
+++ b/js/ui/status/power.js
@@ -49,7 +49,7 @@ const PowerManagerInterface = {
         { name: 'GetPrimaryDevice', inSignature: '', outSignature: '(susbut)' },
         ],
     signals: [
-        { name: 'Changed', outSignature: '' },
+        { name: 'Changed', inSignature: '' },
         ],
     properties: [
         { name: 'Icon', signature: 's', access: 'read' },



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]