[folks] Bug 642861 — FolksLinkedHashSet still alive when exiting Empathy
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [folks] Bug 642861 — FolksLinkedHashSet still alive when exiting Empathy
- Date: Sun, 27 Feb 2011 20:21:34 +0000 (UTC)
commit f436d2d5895b7a91b94a560a74b08f14ffcf3b33
Author: Philip Withnall <philip withnall collabora co uk>
Date: Sun Feb 27 20:19:03 2011 +0000
Bug 642861 â?? FolksLinkedHashSet still alive when exiting Empathy
A self-referencing closure was prevent all Tpf.Personas from being finalised,
which was in turn causing a load of owned objects (such as LinkedHashSets)
from being finalised. Spotted by Guillaume Desmottes <gdesmott gnome org>.
Closes: bgo#642861
NEWS | 2 ++
backends/telepathy/lib/tpf-persona.vala | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/NEWS b/NEWS
index d00ec3a..f216d8a 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Bugs fixed:
* Bug 643247 â?? Folks needs C API documentation
* Bug 643201 â?? folks-inspect can't handle properties which are
List<FieldDetails>
+* Bug 642866 â?? tp-lowlevel leaks TpChannel
+* Bug 642861 â?? FolksLinkedHashSet still alive when exiting Empathy
Overview of changes from libfolks 0.3.5 to libfolks 0.3.6
=========================================================
diff --git a/backends/telepathy/lib/tpf-persona.vala b/backends/telepathy/lib/tpf-persona.vala
index 8bb5155..1bf2b67 100644
--- a/backends/telepathy/lib/tpf-persona.vala
+++ b/backends/telepathy/lib/tpf-persona.vala
@@ -243,9 +243,9 @@ public class Tpf.Persona : Folks.Persona,
contact.notify["alias"].connect ((s, p) =>
{
- if (this._alias != contact.alias)
+ if (this._alias != this.contact.alias)
{
- this._alias = contact.alias;
+ this._alias = this.contact.alias;
this.notify_property ("alias");
}
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]