[gdm] greeter: fix swapped LHS/RHS in icon loading error path



commit 4dad44a175493f1c495a90ba67270ba11c9c1802
Author: Ray Strode <rstrode redhat com>
Date:   Fri Feb 18 17:56:09 2011 -0500

    greeter: fix swapped LHS/RHS in icon loading error path
    
    This nasty bug means in some obscure cases we're going to
    end up using freed memory.

 gui/simple-greeter/gdm-user-chooser-widget.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gui/simple-greeter/gdm-user-chooser-widget.c b/gui/simple-greeter/gdm-user-chooser-widget.c
index 9447e59..4b5a80f 100644
--- a/gui/simple-greeter/gdm-user-chooser-widget.c
+++ b/gui/simple-greeter/gdm-user-chooser-widget.c
@@ -900,7 +900,7 @@ get_pixbuf_from_icon_names (GdmUserChooserWidget *widget,
                                                    TRUE, 8, 1, 1, 1, NULL, NULL);
                 scaled_pixbuf = gdk_pixbuf_scale_simple (pixbuf, size, size, GDK_INTERP_NEAREST);
                 g_object_unref (pixbuf);
-                scaled_pixbuf = pixbuf;
+                pixbuf = scaled_pixbuf;
         }
 
         return pixbuf;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]