[gnumeric] GUI: plus leak.



commit 4388d86354ae9da191687513d3828e13ad1a0f1e
Author: Morten Welinder <terra gnome org>
Date:   Fri Feb 18 13:26:24 2011 -0500

    GUI: plus leak.

 src/dialogs/ChangeLog     |   14 +++++++++-----
 src/dialogs/dialog-quit.c |    4 +++-
 2 files changed, 12 insertions(+), 6 deletions(-)
---
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index b9c801b..4a59e85 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,14 +1,18 @@
+2011-02-18  Morten Welinder  <terra gnome org>
+
+	* dialog-quit.c (show_quit_dialog): Don't leak a ref to "list".
+
 2011-02-17  Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* histogram.ui: add checkbox
-	* dialog-analysis-tools.c (histogram_tool_ok_clicked_cb): read new 
+	* dialog-analysis-tools.c (histogram_tool_ok_clicked_cb): read new
 	checkbox
-	
+
 2011-02-05  Andreas J. Guelzow <aguelzow pyrshep ca>
 
-	* doc-meta-data.ui: don't fix the width of the selection list 
+	* doc-meta-data.ui: don't fix the width of the selection list
 	* workbook-attr.ui: ditto
-	
+
 2011-02-02  Morten Welinder <terra gnome org>
 
 	* Release 1.10.13
@@ -51,7 +55,7 @@
 	* dialog-random-generator-cor.c (random_cor_tool_ok_clicked_cb): ditto
 	* dialog-random-generator.c (random_tool_ok_clicked_cb): ditto
 	* dialog-analysis-tool-principal-components.c
-	(principal_components_tool_ok_clicked_cb): ditto, note that the tool 
+	(principal_components_tool_ok_clicked_cb): ditto, note that the tool
 	never returns errors.
 	* dialog-analysis-tool-wilcoxon-mann-whitney.c
 	(wilcoxon_mann_whitney_tool_ok_clicked_cb): ditto
diff --git a/src/dialogs/dialog-quit.c b/src/dialogs/dialog-quit.c
index b850883..026b6a9 100644
--- a/src/dialogs/dialog-quit.c
+++ b/src/dialogs/dialog-quit.c
@@ -362,6 +362,8 @@ show_quit_dialog (GList *dirty, WBCGtk *wbcg)
 				    -1);
 	}
 
+	g_object_unref (list);
+
 	/* ---------------------------------------- */
 
 	atk_object_set_role (gtk_widget_get_accessible (GTK_WIDGET (dialog)),
@@ -378,7 +380,7 @@ show_quit_dialog (GList *dirty, WBCGtk *wbcg)
 		return TRUE;
 	}
 
-	model = GTK_TREE_MODEL (list);
+	model = gtk_tree_view_get_model (tree);
 	ok = gtk_tree_model_get_iter_first (model, &iter);
 	g_return_val_if_fail (ok, FALSE);
 	quit = TRUE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]