[gnome-shell] workpaceThumbnail: Fix accidental propagation of button releases



commit 914e5d30c72390aac89aaa0a4faa75c20034f77d
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Wed Feb 9 19:19:35 2011 -0500

    workpaceThumbnail: Fix accidental propagation of button releases
    
    A right click was propagating through to the parent actor meaning
    that a right click would activate the workspace twice and leave the
    overview instead of just switching to it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641973

 js/ui/workspaceThumbnail.js |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index df6ab10..2fc6b8e 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -44,8 +44,6 @@ WindowClone.prototype = {
         this._draggable.connect('drag-begin', Lang.bind(this, this._onDragBegin));
         this._draggable.connect('drag-end', Lang.bind(this, this._onDragEnd));
         this.inDrag = false;
-
-        this._selected = false;
     },
 
     setStackAbove: function (actor) {
@@ -91,8 +89,9 @@ WindowClone.prototype = {
     },
 
     _onButtonRelease : function (actor, event) {
-        this._selected = true;
         this.emit('selected', event.get_time());
+
+        return true;
     },
 
     _onDragBegin : function (draggable, time) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]