[gtk+] entry: Don't try to handle Tab in entry completions



commit cf8f3c07f237e0cb28cc5e506bb01532b323194f
Author: Benjamin Otte <otte redhat com>
Date:   Thu Nov 3 22:03:22 2011 +0100

    entry: Don't try to handle Tab in entry completions
    
    Instead, fall through to the default handler after closing the
    completion. This has the advantage of letting the file chooser entry
    capture the tab key properly, so one can't accidentally move out of the
    entry by pressing tab while the completion is popped up.
    
    I also suspect it fixes bugs with weird tab keys and shift/ctrl
    oddities. But who knows...

 gtk/gtkentry.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
---
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index 436a868..7769c5a 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -9527,18 +9527,13 @@ keypress_completion_out:
 	   event->keyval == GDK_KEY_KP_Tab ||
 	   event->keyval == GDK_KEY_ISO_Left_Tab) 
     {
-      GtkDirectionType dir = event->keyval == GDK_KEY_ISO_Left_Tab ? 
-	GTK_DIR_TAB_BACKWARD : GTK_DIR_TAB_FORWARD;
-      
       _gtk_entry_reset_im_context (GTK_ENTRY (widget));
       _gtk_entry_completion_popdown (completion);
 
       g_free (completion->priv->completion_prefix);
       completion->priv->completion_prefix = NULL;
 
-      gtk_widget_child_focus (gtk_widget_get_toplevel (widget), dir);
-
-      return TRUE;
+      return FALSE;
     }
   else if (event->keyval == GDK_KEY_ISO_Enter ||
            event->keyval == GDK_KEY_KP_Enter ||



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]