[evolution] MailFolderCache: Fix a double-free on unsubscribe.



commit 63404e5dc1d21c07abbaa29d0223695d479523a0
Author: Matthew Barnes <mbarnes redhat com>
Date:   Tue Dec 13 13:10:30 2011 -0500

    MailFolderCache: Fix a double-free on unsubscribe.
    
    The 'folders' hash table has a GDestroyNotify callback now,
    but we were still freeing the folder_info struct explicitly.

 mail/mail-folder-cache.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/mail/mail-folder-cache.c b/mail/mail-folder-cache.c
index 51a4b47..eb046c5 100644
--- a/mail/mail-folder-cache.c
+++ b/mail/mail-folder-cache.c
@@ -630,9 +630,8 @@ store_folder_unsubscribed_cb (CamelStore *store,
 	if (si) {
 		mfi = g_hash_table_lookup (si->folders, info->full_name);
 		if (mfi) {
-			g_hash_table_remove (si->folders, mfi->full_name);
 			unset_folder_info (cache, mfi, TRUE, TRUE);
-			free_folder_info (mfi);
+			g_hash_table_remove (si->folders, mfi->full_name);
 		}
 	}
 	g_mutex_unlock (cache->priv->stores_mutex);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]