[gnome-shell] browser-plugin: Fix memory leak when passing an invalid UUID
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] browser-plugin: Fix memory leak when passing an invalid UUID
- Date: Thu, 8 Dec 2011 16:50:53 +0000 (UTC)
commit 02af8eb824bde8cc21b58365772d67e0d6c5992f
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Tue Dec 6 15:00:52 2011 -0500
browser-plugin: Fix memory leak when passing an invalid UUID
https://bugzilla.gnome.org/show_bug.cgi?id=665261
browser-plugin/browser-plugin.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
---
diff --git a/browser-plugin/browser-plugin.c b/browser-plugin/browser-plugin.c
index fccb061..a80a492 100644
--- a/browser-plugin/browser-plugin.c
+++ b/browser-plugin/browser-plugin.c
@@ -480,7 +480,10 @@ plugin_install_extension (PluginObject *obj,
{
gchar *uuid_str = g_strndup (uuid.UTF8Characters, uuid.UTF8Length);
if (!uuid_is_valid (uuid_str))
- return FALSE;
+ {
+ g_free (uuid_str);
+ return FALSE;
+ }
g_dbus_proxy_call (obj->proxy,
"InstallRemoteExtension",
@@ -509,7 +512,10 @@ plugin_uninstall_extension (PluginObject *obj,
uuid_str = g_strndup (uuid.UTF8Characters, uuid.UTF8Length);
if (!uuid_is_valid (uuid_str))
- return FALSE;
+ {
+ g_free (uuid_str);
+ return FALSE;
+ }
res = g_dbus_proxy_call_sync (obj->proxy,
"UninstallExtension",
@@ -543,7 +549,10 @@ plugin_get_info (PluginObject *obj,
uuid_str = g_strndup (uuid.UTF8Characters, uuid.UTF8Length);
if (!uuid_is_valid (uuid_str))
- return FALSE;
+ {
+ g_free (uuid_str);
+ return FALSE;
+ }
res = g_dbus_proxy_call_sync (obj->proxy,
"GetExtensionInfo",
@@ -576,7 +585,10 @@ plugin_get_errors (PluginObject *obj,
uuid_str = g_strndup (uuid.UTF8Characters, uuid.UTF8Length);
if (!uuid_is_valid (uuid_str))
- return FALSE;
+ {
+ g_free (uuid_str);
+ return FALSE;
+ }
res = g_dbus_proxy_call_sync (obj->proxy,
"GetExtensionErrors",
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]