[glom] Remove unused get_sql_format() methods.



commit 4d9ecf7b960d88584156238c20ea66fb6116cf0b
Author: Murray Cumming <murrayc murrayc com>
Date:   Mon Dec 5 14:44:44 2011 +0100

    Remove unused get_sql_format() methods.
    
    * glom/libglom/connectionpool.[h|cc]:
    * glom/libglom/connectionpool_backends/backend.h:
    * glom/libglom/connectionpool_backends/postgres.[h|cc]:
    * glom/libglom/connectionpool_backends/sqlite.[h|cc]: Remove the
    various unused get_sql_format() methods.

 ChangeLog                                        |   10 ++++++++++
 glom/libglom/connectionpool.cc                   |    6 ------
 glom/libglom/connectionpool.h                    |    1 -
 glom/libglom/connectionpool_backends/backend.h   |    4 ----
 glom/libglom/connectionpool_backends/postgres.cc |    5 -----
 glom/libglom/connectionpool_backends/postgres.h  |    1 -
 glom/libglom/connectionpool_backends/sqlite.cc   |    5 -----
 glom/libglom/connectionpool_backends/sqlite.h    |    1 -
 8 files changed, 10 insertions(+), 23 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c83ec22..aa8f59a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2011-12-05  Murray Cumming  <murrayc murrayc com>
 
+	Remove unused get_sql_format() methods.
+
+	* glom/libglom/connectionpool.[h|cc]:
+	* glom/libglom/connectionpool_backends/backend.h:
+	* glom/libglom/connectionpool_backends/postgres.[h|cc]:
+	* glom/libglom/connectionpool_backends/sqlite.[h|cc]: Remove the
+	various unused get_sql_format() methods.
+
+2011-12-05  Murray Cumming  <murrayc murrayc com>
+
 	Field: Remove unused get_gda_holder_string().
 
 	* glom/libglom/data_structure/field.[h|cc]: Remove this 
diff --git a/glom/libglom/connectionpool.cc b/glom/libglom/connectionpool.cc
index c11fe8f..01deaed 100644
--- a/glom/libglom/connectionpool.cc
+++ b/glom/libglom/connectionpool.cc
@@ -476,12 +476,6 @@ Glib::ustring ConnectionPool::get_database() const
   return m_database;
 }
 
-Field::sql_format ConnectionPool::get_sql_format() const
-{
-  g_assert(m_backend.get());
-  return m_backend->get_sql_format();
-}
-
 const FieldTypes* ConnectionPool::get_field_types() const
 {
   return m_pFieldTypes;
diff --git a/glom/libglom/connectionpool.h b/glom/libglom/connectionpool.h
index e0fd497..8362c44 100644
--- a/glom/libglom/connectionpool.h
+++ b/glom/libglom/connectionpool.h
@@ -193,7 +193,6 @@ public:
   Glib::ustring get_password() const;
   Glib::ustring get_database() const;
 
-  Field::sql_format get_sql_format() const;
   const FieldTypes* get_field_types() const;
   Gnome::Gda::SqlOperatorType get_string_find_operator() const;
 
diff --git a/glom/libglom/connectionpool_backends/backend.h b/glom/libglom/connectionpool_backends/backend.h
index a3dba7f..083d9f0 100644
--- a/glom/libglom/connectionpool_backends/backend.h
+++ b/glom/libglom/connectionpool_backends/backend.h
@@ -90,10 +90,6 @@ protected:
   /* TODO: Merge create_database() and initialize() into a single function?
    */
 
-  /** This method specifies the format of values in SQL expressions.
-   */
-  virtual Field::sql_format get_sql_format() const = 0;
-
   /** Whether the database can be accessed from remote machines, once startup()
    * was called.
    */
diff --git a/glom/libglom/connectionpool_backends/postgres.cc b/glom/libglom/connectionpool_backends/postgres.cc
index a6b8ee9..1bda810 100644
--- a/glom/libglom/connectionpool_backends/postgres.cc
+++ b/glom/libglom/connectionpool_backends/postgres.cc
@@ -928,11 +928,6 @@ bool Postgres::create_text_file(const std::string& file_uri, const std::string&
   return true; //Success.
 }
 
-Field::sql_format Postgres::get_sql_format() const
-{
-  return Field::SQL_FORMAT_POSTGRES;
-}
-
 bool Postgres::supports_remote_access() const
 {
   return true;
diff --git a/glom/libglom/connectionpool_backends/postgres.h b/glom/libglom/connectionpool_backends/postgres.h
index 6e79f65..f785025 100644
--- a/glom/libglom/connectionpool_backends/postgres.h
+++ b/glom/libglom/connectionpool_backends/postgres.h
@@ -58,7 +58,6 @@ public:
 
 
 private:
-  virtual Field::sql_format get_sql_format() const;
   virtual bool supports_remote_access() const;
   virtual Gnome::Gda::SqlOperatorType get_string_find_operator() const;
   virtual const char* get_public_schema_name() const;
diff --git a/glom/libglom/connectionpool_backends/sqlite.cc b/glom/libglom/connectionpool_backends/sqlite.cc
index ef43144..dc0eb39 100644
--- a/glom/libglom/connectionpool_backends/sqlite.cc
+++ b/glom/libglom/connectionpool_backends/sqlite.cc
@@ -413,11 +413,6 @@ bool Sqlite::convert_backup(const SlotProgress& /* slot_progress */, const std::
   return false;
 }
 
-Field::sql_format Sqlite::get_sql_format() const
-{
-  return Field::SQL_FORMAT_SQLITE;
-}
-
 bool Sqlite::supports_remote_access() const
 {
   return false;
diff --git a/glom/libglom/connectionpool_backends/sqlite.h b/glom/libglom/connectionpool_backends/sqlite.h
index a7bc2d5..0665be0 100644
--- a/glom/libglom/connectionpool_backends/sqlite.h
+++ b/glom/libglom/connectionpool_backends/sqlite.h
@@ -38,7 +38,6 @@ public:
   Sqlite();
 
 private:
-  virtual Field::sql_format get_sql_format() const;
   virtual bool supports_remote_access() const;
   virtual Gnome::Gda::SqlOperatorType get_string_find_operator() const;
   virtual const char* get_public_schema_name() const;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]