Re: [rygel] core: Dump encodebin profile in transcoder

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

On Sun, Dec 4, 2011 at 1:04 PM, Jens Georg <jensgeorg src gnome org> wrote:
> commit fb28cf1739f37f3a1f4931260d623234e97326bc
> Author: Jens Georg <mail jensge org>
> Date: Â Sun Dec 4 12:01:31 2011 +0100
>
> Â Âcore: Dump encodebin profile in transcoder
>
> Âsrc/rygel/rygel-audio-transcoder.vala | Â Â1 +
> Âsrc/rygel/rygel-gst-utils.vala    Â|  17 +++++++++++++++++
> Âsrc/rygel/rygel-transcoder.vala    |  Â1 +
> Âsrc/rygel/rygel-video-transcoder.vala | Â Â1 +
> Â4 files changed, 20 insertions(+), 0 deletions(-)
> ---
> diff --git a/src/rygel/rygel-audio-transcoder.vala b/src/rygel/rygel-audio-transcoder.vala
> index 6a299b2..0b45be5 100644
> --- a/src/rygel/rygel-audio-transcoder.vala
> +++ b/src/rygel/rygel-audio-transcoder.vala
> @@ -98,6 +98,7 @@ internal class Rygel.AudioTranscoder : Rygel.Transcoder {
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â null,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â null,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 1);
> + Â Â Â Âenc_audio_profile.set_name ("audio");
>
> Â Â Â Â if (this.container_format != null) {
> Â Â Â Â Â Â var enc_container_profile = new EncodingContainerProfile ("container",
> diff --git a/src/rygel/rygel-gst-utils.vala b/src/rygel/rygel-gst-utils.vala
> index 2585eb2..47b36f1 100644
> --- a/src/rygel/rygel-gst-utils.vala
> +++ b/src/rygel/rygel-gst-utils.vala
> @@ -92,6 +92,23 @@ internal abstract class Rygel.GstUtils {
> Â Â Â Â return get_best_depay (features, caps);
> Â Â }
>
> + Â Âpublic static void dump_encoding_profile (EncodingProfile profile,
> +                       Âint       indent = 0) {
> + Â Â Â Âvar indent_s = string.nfill (indent, ' ');
> + Â Â Â Âdebug (indent_s + "Dumping %s", profile.get_name ());

   'Dumping' is a bad term to be used here since all output is
essentially a dump. Also would be good idea to provide slightly more
info here: Using following encoding profile '%s'. Format: %s.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124