[frogr] Fix issue fetching information after changing proxy settings



commit 0ee0f9c07e8e3d5bcbf5766bf737a1422862550b
Author: Mario Sanchez Prada <msanchez igalia com>
Date:   Thu Aug 25 09:37:05 2011 +0200

    Fix issue fetching information after changing proxy settings

 src/frogr-controller.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)
---
diff --git a/src/frogr-controller.c b/src/frogr-controller.c
index a314650..acd7ff2 100644
--- a/src/frogr-controller.c
+++ b/src/frogr-controller.c
@@ -2263,6 +2263,7 @@ frogr_controller_set_proxy (FrogrController *self,
                             const char *username, const char *password)
 {
   FrogrControllerPrivate *priv = NULL;
+  gboolean proxy_changed = FALSE;
 
   g_return_if_fail(FROGR_IS_CONTROLLER (self));
 
@@ -2270,12 +2271,10 @@ frogr_controller_set_proxy (FrogrController *self,
 
   /* The host is mandatory to set up a proxy */
   if (!use_gnome_proxy && (host == NULL || *host == '\0')) {
-    fsp_session_set_http_proxy (priv->session, FALSE,
-                                NULL, NULL, NULL, NULL);
+    proxy_changed = fsp_session_set_http_proxy (priv->session, FALSE,
+                                                NULL, NULL, NULL, NULL);
     DEBUG ("%s", "Not enabling the HTTP proxy");
   } else {
-    gboolean proxy_changed = FALSE;
-
     if (!use_gnome_proxy)
       {
         gchar *auth_part = NULL;
@@ -2298,11 +2297,11 @@ frogr_controller_set_proxy (FrogrController *self,
                                                 use_gnome_proxy,
                                                 host, port,
                                                 username, password);
-
-    /* Re-fetch information if needed after changing proxy configuration */
-    if (priv->app_running && proxy_changed)
-      _fetch_everything (self, FALSE);
   }
+
+  /* Re-fetch information if needed after changing proxy configuration */
+  if (priv->app_running && proxy_changed)
+    _fetch_everything (self, FALSE);
 }
 
 void



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]