[folks] e-d-s: Don't infer we already have an avatar in our cache by its URI
- From: Raul Gutierrez Segales <raulgs src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [folks] e-d-s: Don't infer we already have an avatar in our cache by its URI
- Date: Wed, 17 Aug 2011 18:15:38 +0000 (UTC)
commit 5752726049d9b27af3083f9358a74a29a78e8061
Author: Raul Gutierrez Segales <rgs collabora co uk>
Date: Thu Aug 4 15:55:09 2011 +0100
e-d-s: Don't infer we already have an avatar in our cache by its URI
From libfolks we should discourage using local URIs to
set an EContactPhoto so even if we get inlined EContactPhoto
just do a full content comparison.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=655374
backends/eds/lib/edsf-persona.vala | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
---
diff --git a/backends/eds/lib/edsf-persona.vala b/backends/eds/lib/edsf-persona.vala
index 9328706..f013bd6 100644
--- a/backends/eds/lib/edsf-persona.vala
+++ b/backends/eds/lib/edsf-persona.vala
@@ -751,17 +751,6 @@ public class Edsf.Persona : Folks.Persona,
E.ContactPhoto? p = (E.ContactPhoto) this._get_property ("photo");
var cache = AvatarCache.dup ();
- var cache_uri = cache.build_uri_for_avatar (this.uid);
-
- /* Check the avatar isn't being set by our PersonaStore; if it is, just
- * notify the property and bail. This avoids circular updates to the
- * cache. */
- if (p != null &&
- p.type == ContactPhotoType.URI && p.get_uri () == cache_uri)
- {
- this.notify_property ("avatar");
- return;
- }
// Convert the ContactPhoto to a LoadableIcon and store or update it.
var new_avatar = this._contact_photo_to_loadable_icon (p);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]